Closed Bug 769372 Opened 10 years ago Closed 7 years ago

GCLI inspect command steals focus, it shouldn't

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
wip - might even work
Assignee: nobody → mratcliffe
Joe's approach sounds good.

Maybe you want to use a "focus" argument (instead of "leaveFocus"), and use a default value:
> openInspectorUI: function IUI_openInspectorUI(aNode, focus=true)
(ES6 yeah!)

Or have a specific function:
> openInspectorAndDontStealFocus(aNode)
Attached patch v2Splinter Review
Not tested properly because I'm fighting the build system right now, but visually it looks right, and that's all that matters, right?
Assignee: mratcliffe → jwalker
Attachment #637610 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #639283 - Flags: review?(paul)
Attachment #639283 - Flags: feedback?(vporof)
Attachment #639283 - Flags: review?(paul) → review+
Attachment #639283 - Flags: feedback?(vporof)
Target Milestone: Firefox 16 → Firefox 17
Triage
Target Milestone: Firefox 17 → Firefox 18
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools: Console → Developer Tools: Graphic Commandline and Toolbar
This bug was not fixed with Firefox 18.
Target Milestone: Firefox 18 → Future
Blocks: GCLICMD
Resetting priorities because these P* levels are very out of date.
Sorry for the bug spam. Filter on Lobster Thermidor
Priority: P1 → --
I'm not clear that it's even right that gcli should keep focus here, I don't think this is worth tracking.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.