Closed Bug 769377 Opened 7 years ago Closed 7 years ago

Build warning: jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [...] base ‘js::Wrapper’ [-Wreorder]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

../../../mozilla/js/src/jswrapper.cpp: In constructor ‘js::AbstractWrapper::AbstractWrapper(unsigned int)’:
../../../mozilla/js/src/jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:129:18: warning:   base ‘js::Wrapper’ [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:127:1: warning:   when initialized here [-Wreorder]

Basically: the two parent-class constructors invoked by the AbstractWrapper constructor's init list are listed in the wrong order. (They're backwards from how they're listed in the class definition.)
Attached patch fixSplinter Review
This fixes it.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #637608 - Flags: review?(bobbyholley+bmo)
Comment on attachment 637608 [details] [diff] [review]
fix

Nevermind -- Eddy's going to be touching this code further in bug 703537, so I believe he's going to fix this over there.
Attachment #637608 - Flags: review?(bobbyholley+bmo)
Assignee: dholbert → general
Status: ASSIGNED → NEW
(We can just resolve this as WFM when the next patch on bug 703537 lands)
Resolving as FIXED by this changeset (from bug 703537):
  http://hg.mozilla.org/mozilla-central/rev/53e0f8e066f4#l1.12
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.