The default bug view has changed. See this FAQ.

Build warning: jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [...] base ‘js::Wrapper’ [-Wreorder]

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
../../../mozilla/js/src/jswrapper.cpp: In constructor ‘js::AbstractWrapper::AbstractWrapper(unsigned int)’:
../../../mozilla/js/src/jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:129:18: warning:   base ‘js::Wrapper’ [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:127:1: warning:   when initialized here [-Wreorder]

Basically: the two parent-class constructors invoked by the AbstractWrapper constructor's init list are listed in the wrong order. (They're backwards from how they're listed in the class definition.)
(Reporter)

Updated

5 years ago
Blocks: 187528
(Reporter)

Comment 1

5 years ago
Created attachment 637608 [details] [diff] [review]
fix

This fixes it.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #637608 - Flags: review?(bobbyholley+bmo)
(Reporter)

Comment 2

5 years ago
Comment on attachment 637608 [details] [diff] [review]
fix

Nevermind -- Eddy's going to be touching this code further in bug 703537, so I believe he's going to fix this over there.
Attachment #637608 - Flags: review?(bobbyholley+bmo)
(Reporter)

Updated

5 years ago
Assignee: dholbert → general
Status: ASSIGNED → NEW
(Reporter)

Comment 3

5 years ago
(We can just resolve this as WFM when the next patch on bug 703537 lands)
(Reporter)

Comment 4

5 years ago
Resolving as FIXED by this changeset (from bug 703537):
  http://hg.mozilla.org/mozilla-central/rev/53e0f8e066f4#l1.12
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.