Last Comment Bug 769377 - Build warning: jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [...] base ‘js::Wrapper’ [-Wreorder]
: Build warning: jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks: buildwarning 703537
  Show dependency treegraph
 
Reported: 2012-06-28 11:19 PDT by Daniel Holbert [:dholbert]
Modified: 2012-07-06 11:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (563 bytes, patch)
2012-06-28 11:22 PDT, Daniel Holbert [:dholbert]
no flags Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-06-28 11:19:15 PDT
../../../mozilla/js/src/jswrapper.cpp: In constructor ‘js::AbstractWrapper::AbstractWrapper(unsigned int)’:
../../../mozilla/js/src/jswrapper.cpp:129:18: warning: base ‘js::IndirectProxyHandler’ will be initialized after [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:129:18: warning:   base ‘js::Wrapper’ [-Wreorder]
../../../mozilla/js/src/jswrapper.cpp:127:1: warning:   when initialized here [-Wreorder]

Basically: the two parent-class constructors invoked by the AbstractWrapper constructor's init list are listed in the wrong order. (They're backwards from how they're listed in the class definition.)
Comment 1 Daniel Holbert [:dholbert] 2012-06-28 11:22:43 PDT
Created attachment 637608 [details] [diff] [review]
fix

This fixes it.
Comment 2 Daniel Holbert [:dholbert] 2012-06-28 14:38:14 PDT
Comment on attachment 637608 [details] [diff] [review]
fix

Nevermind -- Eddy's going to be touching this code further in bug 703537, so I believe he's going to fix this over there.
Comment 3 Daniel Holbert [:dholbert] 2012-06-28 14:38:54 PDT
(We can just resolve this as WFM when the next patch on bug 703537 lands)
Comment 4 Daniel Holbert [:dholbert] 2012-07-06 11:10:07 PDT
Resolving as FIXED by this changeset (from bug 703537):
  http://hg.mozilla.org/mozilla-central/rev/53e0f8e066f4#l1.12

Note You need to log in before you can comment on or make changes to this bug.