Right now we assert that the src is a file. This is kinda bad because this function is intended to return a boolean value and not to throw an exception. assert os.path.isfile(src), 'Installer has to be a file' Instead we should return false if src is not a file.
6 years ago
Comment on attachment 637614 [details] Patch sounds good to me
https://github.com/mozilla/mozbase/commit/4f024605b1630003c804096c53a930a761510cd6 I will also bump the version of mozinstall and release on pypi so we can make use of it in our mozmill-automation package.
Version bump to 1.1: https://github.com/mozilla/mozbase/commit/588c89e8a3f259413d08f58747a17a0c7b22ae2d Created tag: https://github.com/mozilla/mozbase/tree/mozinstall-1.1 Release 1.1 on PyPI: http://pypi.python.org/pypi/mozInstall/1.1