769449 - Maintain text selection on device rotation

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

We punted on this in bug 766556, since we're trying to get text selection landed on aurora ASAP, but we should fix this when we get the chance.

Comment 1

[Aaron Train [:aaronmt]]

This is fixed with your recent work.

Comment 2

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #1)
> This is fixed with your recent work.

Are you sure? When I rotate my phone on Nightly I see the selection disappear.

Comment 3

[Aaron Train [:aaronmt]]

You're right. I see that too. This did work though didn't it?

Comment 4

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #3)
> You're right. I see that too. This did work though didn't it?

Nope, I don't think so.

Comment 5

[Mark Capella [:capella]]

Wow old bug :-) This is caused here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/SelectionHandler.js?mark=90-94#89

Comment 6

[:Margaret Leibovic]

(In reply to Mark Capella [:capella] from comment #5)
> Wow old bug :-) This is caused here:
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> SelectionHandler.js?mark=90-94#89

Yes, this was an intentional decision. Fixing this will require adding new functionality, rather than tweaking code to fix a problem.

Comment 7

[Mark Capella [:capella]]

I think recent changes have solved for this.

Comment 8

[:Margaret Leibovic]

(In reply to Mark Capella [:capella] from comment #7)
> I think recent changes have solved for this.

Testing this out, it looks like recent changes must have actually broken this! We currently don't update the handle position on rotation, so the handles end up in the wrong spot. Is there another bug filed on that? If not, we can morph this one to cover it.

Comment 9

[Mark Capella [:capella]]

Oh, I thought it worked because in my patch queue I'm building with the final piece of bug 895463 (p4) (which will need approval from you and kats).

It's ready, but I've got it backlogged / dependent on bug 994664 and before that bug 980074, both of which are waiting approval from wesj.

Comment 10

[Mark Capella [:capella]]

Trying again ... bug 895463 (p4) is in, and it looks like this bug is solved / closeable as a result.

margaret or aaronmt: can you confirm this/these ?