Last Comment Bug 769460 - Add a build time option for enabling per-window private browsing
: Add a build time option for enabling per-window private browsing
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari (out sick)
:
Mentors:
Depends on:
Blocks: PBnGen 722987 722993
  Show dependency treegraph
 
Reported: 2012-06-28 14:28 PDT by :Ehsan Akhgari (out sick)
Modified: 2012-07-09 18:04 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (994 bytes, patch)
2012-07-06 12:08 PDT, :Ehsan Akhgari (out sick)
mh+mozilla: review+
Details | Diff | Review

Description :Ehsan Akhgari (out sick) 2012-06-28 14:28:33 PDT
It's about time for us to add a build-time option for per-window private browsing, so that we can focus on getting the latest remaining pieces landed on mozilla-central without having to switch to a feature which is half-done on Nightly.  We'll develop the parts which can only be turned on whole-sale behind this build-time flag, and once we're ready, we'll turn it on by default, and remove the old code which relies on global private browsing.

The configure option can be called --enable-per-window-private-browsing, and the macro defined by it can be called MOZ_PER_WINDOW_PRIVATE_BROWSING.  Or feel free to choose any other name, the naming is the least important part.  :-)
Comment 1 Mike Hommey [:glandium] 2012-06-28 14:37:06 PDT
No need for a configure option, just AC_SUBST(MOZ_PER_WINDOW_PRIVATE_BROWSING), and export MOZ_PER_WINDOW_PRIVATE_BROWSING=1 in your mozconfig instead of ac_add_options --enable-per-window-private-browsing.
Comment 2 :Ehsan Akhgari (out sick) 2012-06-28 15:53:19 PDT
(In reply to Mike Hommey [:glandium] from comment #1)
> No need for a configure option, just
> AC_SUBST(MOZ_PER_WINDOW_PRIVATE_BROWSING), and export
> MOZ_PER_WINDOW_PRIVATE_BROWSING=1 in your mozconfig instead of
> ac_add_options --enable-per-window-private-browsing.

That's an excellent suggestion, thanks!
Comment 3 :Ehsan Akhgari (out sick) 2012-07-06 12:08:34 PDT
Created attachment 639756 [details] [diff] [review]
Patch (v1)

Stealing this, as it seems like we really need it soon.
Comment 4 :Ehsan Akhgari (out sick) 2012-07-09 08:23:40 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a895c39732ff
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-09 18:04:16 PDT
https://hg.mozilla.org/mozilla-central/rev/a895c39732ff

Note You need to log in before you can comment on or make changes to this bug.