Closed Bug 769490 Opened 7 years ago Closed 7 years ago

Merge metrofx l10n.ini information into browser/locales

Categories

(Firefox for Metro Graveyard :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [completed-elm])

Attachments

(1 file, 1 obsolete file)

From Axel via an email thread:

> So, as we're having one firefox deliverable that we localize, we'll need 
> to hook up the metro l10n files as part of browser, I think, and not as 
> part of an independent product.
> 
> Thus, there shouldn't be a separate l10n.ini, but the one in 
> browser/locales should reference browser/metro along the other dirs that 
> belong to Firefox itself.
> 
> Asa, I think we'd like to keep langpacks as an option.
> 
> We may need to modify the generic install.rdf in browser to be compat 
> with the metro app, if that's using a different app id.

metro specific locale info is currently in 

http://mxr.mozilla.org/projects-central/source/elm/browser/metro/locales/
Blocks: metro-l10n
Component: Build Config → General
Product: Firefox → Firefox for Metro
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: nobody → jmathies
Comment on attachment 694041 [details] [diff] [review]
patch v.1

Axel, I wasn't sure how detailed I needed to be in listing directories under the [compare] section. Will this suffice or do we need a more detailed list that points into the locales directories?
Attachment #694041 - Flags: review?(l10n)
Comment on attachment 694041 [details] [diff] [review]
patch v.1

Review of attachment 694041 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, you'll also need to adapt browser/locales/filter.py to take the new directory into account, at http://mxr.mozilla.org/mozilla-central/source/browser/locales/filter.py#8.
Attachment #694041 - Flags: review?(l10n) → feedback+
Axel, is there a wiki page describing the steps to do a local repack? I'd like to test the metro bits w/l10n build steps, but haven't found much on what we do here.
Hmm, I really don't understand what filter.py is supposed to do, so I'm not sure how to modify it.
https://developer.mozilla.org/en-US/docs/Creating_a_Language_Pack has info on how to do repacks for desktop. I suggest french or italian as example languages.

Also, filter.py controls which files and entries within matter for l10n, as it's not always 1-to-1. You'll need to add 'browser/metro' next to 'browser' in the initial test, and after that things should not need changes. If they would, that'd probably be a bug, like region.properties and search ;-)
(In reply to Axel Hecht [:Pike] from comment #6)
> https://developer.mozilla.org/en-US/docs/Creating_a_Language_Pack has info
> on how to do repacks for desktop. I suggest french or italian as example
> languages.
> 
> Also, filter.py controls which files and entries within matter for l10n, as
> it's not always 1-to-1. You'll need to add 'browser/metro' next to 'browser'
> in the initial test, and after that things should not need changes. If they
> would, that'd probably be a bug, like region.properties and search ;-)

Thank you, will update.

I've been poking through logs and pushing stuff at try. Found pymake l10n-check which has helped me step through the pack/unpack process.
Attached patch patch v.2Splinter Review
Attachment #694041 - Attachment is obsolete: true
Attachment #694876 - Flags: review?(l10n)
Comment on attachment 694876 [details] [diff] [review]
patch v.2

Review of attachment 694876 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #694876 - Flags: review?(l10n) → review+
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.