Last Comment Bug 769514 - Kill the Mac bitmap fallback code in nsSVGOuterSVGFrame
: Kill the Mac bitmap fallback code in nsSVGOuterSVGFrame
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Jonathan Watt [:jwatt] (back in October - email directly if necessary)
:
Mentors:
Depends on: 772313 732819
Blocks: 614732
  Show dependency treegraph
 
Reported: 2012-06-28 18:24 PDT by Jonathan Watt [:jwatt] (back in October - email directly if necessary)
Modified: 2012-07-09 18:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.35 KB, patch)
2012-06-28 18:27 PDT, Jonathan Watt [:jwatt] (back in October - email directly if necessary)
roc: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 18:24:50 PDT
Roc tells me that with Layers we shouldn't be drawing direct to the window, so it seems like the bitmap fallback code in nsSVGOuterSVGFrame is useless and should just be removed.
Comment 1 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 18:27:09 PDT
Created attachment 637750 [details] [diff] [review]
patch
Comment 2 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 18:38:26 PDT
Err, ignore the nsSVGGlyphFrame.cpp change.
Comment 3 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 18:57:45 PDT
Just for record keeping, this was previously tried in bug 411334.
Comment 4 Robert O'Callahan (:roc) (email my personal email if necessary) 2012-06-28 19:15:47 PDT
Comment on attachment 637750 [details] [diff] [review]
patch

Review of attachment 637750 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with that

::: layout/svg/base/src/nsSVGOuterSVGFrame.cpp
@@ +492,5 @@
>  #endif
>  
>    aContext->PushState();
> +  frame->Paint(aBuilder, aContext, mVisibleRect, ToReferenceFrame());
> +  aContext->PopState();

we shouldn't need this PushState/PopState pair. Try removing it.
Comment 5 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-07-05 08:19:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/caaf9085c7d8
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-05 17:19:39 PDT
https://hg.mozilla.org/mozilla-central/rev/caaf9085c7d8

Note You need to log in before you can comment on or make changes to this bug.