The default bug view has changed. See this FAQ.

Kill the Mac bitmap fallback code in nsSVGOuterSVGFrame

RESOLVED FIXED in mozilla16

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Depends on: 1 bug)

Trunk
mozilla16
All
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Roc tells me that with Layers we shouldn't be drawing direct to the window, so it seems like the bitmap fallback code in nsSVGOuterSVGFrame is useless and should just be removed.
(Assignee)

Comment 1

5 years ago
Created attachment 637750 [details] [diff] [review]
patch
Attachment #637750 - Flags: review?(roc)
(Assignee)

Comment 2

5 years ago
Err, ignore the nsSVGGlyphFrame.cpp change.
(Assignee)

Comment 3

5 years ago
Just for record keeping, this was previously tried in bug 411334.
Comment on attachment 637750 [details] [diff] [review]
patch

Review of attachment 637750 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with that

::: layout/svg/base/src/nsSVGOuterSVGFrame.cpp
@@ +492,5 @@
>  #endif
>  
>    aContext->PushState();
> +  frame->Paint(aBuilder, aContext, mVisibleRect, ToReferenceFrame());
> +  aContext->PopState();

we shouldn't need this PushState/PopState pair. Try removing it.
Attachment #637750 - Flags: review?(roc) → review+
(Assignee)

Updated

5 years ago
Blocks: 614732
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/caaf9085c7d8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/caaf9085c7d8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 772313
You need to log in before you can comment on or make changes to this bug.