769605 - Remove Composer's use of cmd_increaseFont/cmd_decreaseFont

Status: NEW

(SeaMonkey :: Composer, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Bug 767684 is a regression in the functionality of the increase/decreaseFontSize commands (cmd_increaseFont/cmd_decreaseFont), apparently caused by bug 590640.  Ehsan and I are agreed that we'd really just like to get rid of these commands entirely, for the reasons explained in bug 769604 comment 0.  Thunderbird devs seem okay with removing them; is Composer also willing to?

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(The only use seems to be in editor/ui/composer/content/editorOverlay.xul, according to MXR.)

Comment 2

[(no longer active)]

It would be great if someone who knows which version of SeaMonkey corresponds to Gecko 15 set the appropriate flag.  Without this being fixed soon, we're unfortunately going to have to back out bug 590640 which is currently on Aurora.

Comment 3

[[e-mail]]

What's the STR to reproduce the bug in Composer? I tried pasting the source from an example from bug 767684 but I didn't see any issues.

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I don't have Composer installed, but this should do it (from bug 767684 comment 11):

1) Type "foobarbaz"

2) Select "bar" and make it bold

3) Select all and increase font size

Only "baz"'s font size increases.  Everything's size should increase.  So the command is pretty much totally broken -- it causes completely incorrect results in very simple cases.

Comment 5

[[e-mail]]

(In reply to Aryeh Gregor from comment #4)
> 1) Type "foobarbaz"
> 
> 2) Select "bar" and make it bold
> 
> 3) Select all and increase font size
> 
> Only "baz"'s font size increases.  Everything's size should increase.
I see everything increase in size... this is with a build I made 40 hours ago.

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

How about:

1) Type "foo", Enter, "bar", Enter, "baz"

2) Select "bar"

3) Indent

4) Increase font size

In contenteditable in Gecko, I see the contents of the blockquote become "bar<big><br></big>", which means the height of the line increases but the size of the selected text does not.  Can you reproduce that?

Comment 7

[Phoenix]

It works in *Message composer*, but doesn't work in *Composer*
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 SeaMonkey/2.13a1
Build identifier: 20120701003014

Comment 8

[[e-mail]]

I was able to reproduce the bug by enclosing the foobarbaz in a block before embiggening it.