The default bug view has changed. See this FAQ.

autobinscope.py uses win line endings and doesn't dump failure logs

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla16
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 637860 [details] [diff] [review]
nix win line endings in autobinscope.py

no code changes, just stripping out the wrong line endings.
Attachment #637860 - Flags: review?(khuey)
(Assignee)

Comment 2

5 years ago
Created attachment 637861 [details] [diff] [review]
dump binscope log on failure

When this fails we should dump the binscope log into the tinderbox logs for easy debugging.
Attachment #637861 - Flags: review?(khuey)
Attachment #637860 - Flags: review?(khuey) → review+
Comment on attachment 637861 [details] [diff] [review]
dump binscope log on failure

Review of attachment 637861 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/win32/autobinscope.py
@@ +71,4 @@
>    print "TEST-UNEXPECTED-FAIL | autobinscope.py | %s is missing a needed Windows protection, such as /GS or ASLR" % binary_path
> +  logfile = open(log_file_path, "r")
> +  for line in logfile:
> +    print(line),

Extraneous comma?
Attachment #637861 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

5 years ago
> > +    print(line),
> 
> Extraneous comma?

nope, this avoids double spacing each line. I guess print adds it's own return character, and the log has those as well.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31f6253167
https://hg.mozilla.org/integration/mozilla-inbound/rev/05a436f462e7
https://hg.mozilla.org/mozilla-central/rev/2a31f6253167
https://hg.mozilla.org/mozilla-central/rev/05a436f462e7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.