Last Comment Bug 769623 - autobinscope.py uses win line endings and doesn't dump failure logs
: autobinscope.py uses win line endings and doesn't dump failure logs
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla16
Assigned To: Jim Mathies [:jimm]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-29 05:15 PDT by Jim Mathies [:jimm]
Modified: 2012-07-13 20:23 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
nix win line endings in autobinscope.py (5.77 KB, patch)
2012-06-29 05:16 PDT, Jim Mathies [:jimm]
khuey: review+
Details | Diff | Splinter Review
dump binscope log on failure (653 bytes, patch)
2012-06-29 05:17 PDT, Jim Mathies [:jimm]
khuey: review+
Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2012-06-29 05:15:31 PDT

    
Comment 1 Jim Mathies [:jimm] 2012-06-29 05:16:52 PDT
Created attachment 637860 [details] [diff] [review]
nix win line endings in autobinscope.py

no code changes, just stripping out the wrong line endings.
Comment 2 Jim Mathies [:jimm] 2012-06-29 05:17:58 PDT
Created attachment 637861 [details] [diff] [review]
dump binscope log on failure

When this fails we should dump the binscope log into the tinderbox logs for easy debugging.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-02 10:11:12 PDT
Comment on attachment 637861 [details] [diff] [review]
dump binscope log on failure

Review of attachment 637861 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/win32/autobinscope.py
@@ +71,4 @@
>    print "TEST-UNEXPECTED-FAIL | autobinscope.py | %s is missing a needed Windows protection, such as /GS or ASLR" % binary_path
> +  logfile = open(log_file_path, "r")
> +  for line in logfile:
> +    print(line),

Extraneous comma?
Comment 4 Jim Mathies [:jimm] 2012-07-02 10:18:36 PDT
> > +    print(line),
> 
> Extraneous comma?

nope, this avoids double spacing each line. I guess print adds it's own return character, and the log has those as well.

Note You need to log in before you can comment on or make changes to this bug.