769655 - The installer fails if SeaMonkey was configured with --disable-necko-wifi

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Andrew Benton]

Attachment: seamonkey-installer-necko-wifi.patch [Checked in: See comment 4]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120628163319

Steps to reproduce:

Compiled Seamonkey with ac_add_options --disable-necko-wifi in my mozconfig


Actual results:

When I ran make -C moz-build-dir/suite/installer it failed

Error: package error or possible missing or unnecessary file: 
bin/components/necko_wifi.xpt (package-manifest, 155).



Expected results:

It should have built a seamonkey tarball. The attached patch (with code lifted from the browser/installer in current mozilla-central) fixes the issue for me.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 637898 [details] [diff] [review]
seamonkey-installer-necko-wifi.patch
[Checked in: See comment 4]

Not sure on my ETA for this one, so giving serge authority to review this.

Comment 2

[Philip Chee]

See also Firefox Bug 739132: --disable-necko-wifi causes "Error: package error or possible missing or unnecessary file: bin/components/necko_wifi.xpt"

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 637898 [details] [diff] [review]
seamonkey-installer-necko-wifi.patch
[Checked in: See comment 4]

Review of attachment 637898 [details] [diff] [review]:
-----------------------------------------------------------------

approval‑comm‑aurora=me, as regression fix.

approval‑comm‑beta=?, assuming bug 745998 gets approved first.

::: suite/installer/Makefile.in
@@ +93,2 @@
>  DEFINES += -DMOZ_MOVEMAIL=1
>  endif

This is actually porting bug 751597 :-)

Nit: move it to between LOCALE_BUILD=1 and WIN_OR_OS2=1.

::: suite/installer/package-manifest.in
@@ +258,4 @@
>  @BINPATH@/components/necko_strconv.xpt
>  @BINPATH@/components/necko_viewsource.xpt
>  @BINPATH@/components/necko_websocket.xpt
> +#ifdef NECKO_WIFI

"Good catch".
I fixed this in bug 745998 comment 6.

Comment 4

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-beta/rev/bf7542ac74d6

Comment 5

[Justin Wood (:Callek)]

serge, needed on aurora?

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #5)
> serge, needed on aurora?

Yes, see comment 3.

Comment 7

[Philip Chee]

Comment on attachment 637898 [details] [diff] [review]
seamonkey-installer-necko-wifi.patch
[Checked in: See comment 4]

> (In reply to Justin Wood (:Callek) from comment #5)
>> serge, needed on aurora?
> Yes, see comment 3.

[Approval Request Comment]
Regression caused by (bug #): Bug 751597
User impact if declined: Linux and other packagers won't be able to package builds with |ac_add_options --disable-necko-wifi|.
Testing completed (on m-c, etc.):  baked on comm-central
Risk to taking this patch (and alternatives if risky): Risks are low to none as official builds don't build with this option.
String changes made by this patch: none.

Comment 8

[Serge Gautherie (:sgautherie)]

Andrew, can you update your patch per comment 3?

Comment 9

[Justin Wood (:Callek)]

(In reply to Serge Gautherie (:sgautherie) from comment #8)
> Andrew, can you update your patch per comment 3?

serge, I'm pushing this to aurora/trunk right now. Later this evening (after uplift) you have rs+=/a=me to do that nit change.

Andrew thanks for the patch!

http://hg.mozilla.org/releases/comm-aurora/rev/080567bfa72f
http://hg.mozilla.org/comm-central/rev/a4640c86e3a3