Closed Bug 769693 Opened 12 years ago Closed 12 years ago

Add logic to detect missing/invalid manifests in public apps and re-review

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

x86_64
Windows 7
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eviljeff, Assigned: robhudson)

References

Details

An app developer can delete the manifest, or edit it to make it non-installable, after we approve it.  This should go for re-review so we can reject the app and tell the developer why (so they can fix and resubmit it).
Don't we already do this with the daily cron job?
Priority: -- → P4
If it fails to fetch it, we just log:
https://github.com/mozilla/zamboni/blob/master/mkt/webapps/tasks.py#L57

Can we detail this out a little more?  If the manifest is unreachable, should we put it in the re-review queue for follow-up? This might cause false positives for server hiccups but maybe that's an acceptable thing.

If we can get it, should we revalidate it to check for breaking updates? And if it fails validation send it to the re-review queue?

There's another bug to detect an app name change... is there anything else in the manifest we should try to catch and send to re-review?
(In reply to Rob Hudson [:robhudson] from comment #2)
> If the manifest is unreachable, should we put it in the re-review queue for 
> follow-up? This might cause false positives for server hiccups but maybe that's an
> acceptable thing.

I think we should.  At the time of the re-review the reviewer will check it again - if the server is down at the time of cron job and the re-review the its likely something we should do something about so users aren't offered broken apps.

> If we can get it, should we revalidate it to check for breaking updates? And
> if it fails validation send it to the re-review queue?

IMO, yes, for the same reason as the manifest being missing.

> There's another bug to detect an app name change... is there anything else
> in the manifest we should try to catch and send to re-review?

I can't think of anything else right now but we can add more later if necessary.
Assignee: nobody → robhudson.mozbugs
https://github.com/mozilla/zamboni/commit/d7c1b08
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.