Open Bug 769719 Opened 12 years ago Updated 2 years ago

Consider not holding a reference to the idle service in the Window

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
REOPENED

People

(Reporter: khuey, Unassigned)

References

(
URL
)

Details

This seems really hacky to me, especially since we have to hook this up to the cycle collector to handle the mock idle service case.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #0)
> This seems really hacky to me, especially since we have to hook this up to
> the cycle collector to handle the mock idle service case.

Kyle what seems really hacky? There is not reference to the hacky part in the commment above.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #0)
> This seems really hacky to me, especially since we have to hook this up to
> the cycle collector to handle the mock idle service case.

Kyle what seems really hacky? There is no reference the hacky part or the patch/code.
I think it's hacky that we have to hook mIdleService up to the cycle collector to handle the mock idle service case.  It seems like it would be simpler to drop the idle service reference entirely.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> I think it's hacky that we have to hook mIdleService up to the cycle
> collector to handle the mock idle service case.  It seems like it would be
> simpler to drop the idle service reference entirely.

Discussed. Nothing to do.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> I think it's hacky that we have to hook mIdleService up to the cycle
> collector to handle the mock idle service case.  It seems like it would be
> simpler to drop the idle service reference entirely.

Discussed. Nothing to do.

comment for wrong bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Current status from a while back. Patch creates oranges on try but was tested on local machine and passes the same tests. The idle API currently functions properly without this patch.
Component: DOM → DOM: Core & HTML

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: bsurender → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.