Closed Bug 769768 Opened 12 years ago Closed 12 years ago

Hardcoded "Firefox" in sync_strings.dtd

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: rimas, Unassigned)

References

Details

Bug 766499 and https://hg.mozilla.org/mozilla-central/rev/829abeedcde4 have introduced a hardcoded instance of the name "Firefox" in sync_strings.dtd (specifically, in sync.subtitle.failmultiple.label). The &brandShortName; placeholder should have been used instead.

There's also an occurrence of Firefox in the same file, in string sync.subtitle.connectlocation.label, that could also be fixed.
As I understand it, brandShortName adapts to the product -- it's "Nightly" for Nightly builds.

There's Bug 764867 (and perhaps another, recently fixed) for branding issues, but this particular case is not a bug.

The string to which you refer is describing "the set of Firefox applications" -- Nightly, Aurora, Beta, Firefox, and personal Fennec builds. Assuming that I'm understanding brandShortName correctly, it's not the correct string to use for this; "Firefox" is. Users won't have multiple versions of Aurora installed; they'll have Aurora and Firefox Beta, for example, and we describe that as "multiple versions of Firefox".

If you can point me to an entity that's always "Firefox", then please reopen this bug.

Thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Hi Richard and thanks for your explanation! I don't think we have a string that would always say Firefox, so I guess this is a valid reason to hardcode the name instead.
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.