Closed Bug 769864 Opened 12 years ago Closed 12 years ago

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/common/tests/unit/test_storageservice_client.js | [object Object] == null

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file, 1 obsolete file)

Match client and server time in test, v2
4.11 KB, patch
rnewman
: review+
Details | Diff | Splinter Review 
Looks like I introduced an intermittent orange with the storage service 2.0 client.

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/common/tests/unit/test_storageservice_client.js | [object Object] == null

https://tbpl.mozilla.org/php/getParsedLog.php?id=13118886&tree=Services-Central

Hopefully I can fix this before s-c merges into m-c.
I believe this will fix it.

The underlying problem is that the test assumed the collection timestamp was equivalent to the BSO's timestamp. Unfortunately, this isn't how the createCollection() API works on the JS server. That is arguably wrong, but whatever.

By setting the client's time to what the server has, we will not error in the case where the clock advances between when the time was retrieved and when the collection was created.

https://tbpl.mozilla.org/?tree=Try&rev=b80c3c47ba41 should confirm this fix.
Attachment #638435 - Flags: review?(rnewman)
Fixed a few more instances in the test.

This patch holds up the next s-c train. Please make it the top review in patches from me.
Attachment #638435 - Attachment is obsolete: true
Attachment #638435 - Flags: review?(rnewman)
Attachment #638454 - Flags: review?(rnewman)
Comment on attachment 638454 [details] [diff] [review]
Match client and server time in test, v2

Review of attachment 638454 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Note that your first assignment doesn't appear to be used...
Attachment #638454 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/services/services-central/rev/d07cb07160dd
Whiteboard: [orangefactor] → [fixed in services]
Target Milestone: --- → mozilla16
Try run for b80c3c47ba41 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b80c3c47ba41
Results (out of 31 total builds):
    success: 28
    warnings: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/gszorc@mozilla.com-b80c3c47ba41
https://hg.mozilla.org/mozilla-central/rev/d07cb07160dd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: