Created attachment 638228 [details] Screenshot of tabbar showing regression When the window is inactive, the tab bar background does not change to match the title and navigation toolbars. Courtesy of hg bisect: The first bad revision is: changeset: 98008:bd0a91621ea9 user: Matt Woodrow <firstname.lastname@example.org> date: Sat Jun 30 15:06:10 2012 +1200 summary: Bug 539356 - Part 8b - Move painting of retained layers to the view manager flush, and only composite on the paint event. r=roc
More fallout from bug 539356.
DLBI may not land in 16 though, so re-noming while we figure that out.
DLBI appears to be targeted for 17 at this point. Please set tracking-firefox16 to ? if you're still running into this on Aurora 16.
Created attachment 652098 [details] Screenshot of DownThemAll window This bug appeared again with the relanding of parts of DLBI. It appears that whatever is directly below the title bar is rendered incorrectly. I have my tabs set to be low the navigation bar and for me, the navigation bar keeps the active state while the tab bar becomes inactive.
@Matt: These "|| ![NSView focusView]" conditions are responsible for this and can be removed: http://mxr.mozilla.org/mozilla-central/search?string=![NSView+focusView] I added them so that tab snapshots captured in inactive windows have active-looking toolbars in them, but that behavior was never very sane and can go.
Created attachment 652538 [details] [diff] [review] Remove ![NSView focusView] conditions Any idea why my patches would have affected this?
Comment on attachment 652538 [details] [diff] [review] Remove ![NSView focusView] conditions Before your patches, painting toolbars only happened inside a call to drawRect. The callers of drawRect (somewhere in Cocoa) wrap that call in [view lockFocus] / [view unlockFocus], so [NSView focusView] was non-null during painting.
This still happens with the error console, download manager :(.
Can you file a new bug, and attach a screenshot/describe in more detail?
Problem solved in the latest beta : Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0 , Build ID: 20121023124120.
mass remove verifyme requests greater than 4 months old