tab bar background does not change when window goes inactive (background/unfocused window title bars look wrong)

RESOLVED FIXED in Firefox 17

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: mozilla, Assigned: mattwoodrow)

Tracking

({regression})

Trunk
mozilla17
x86_64
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(firefox16-, firefox17+ verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 638228 [details]
Screenshot of tabbar showing regression

When the window is inactive, the tab bar background does not change to match the title and navigation toolbars.

Courtesy of hg bisect:

The first bad revision is:
changeset:   98008:bd0a91621ea9
user:        Matt Woodrow <mwoodrow@mozilla.com>
date:        Sat Jun 30 15:06:10 2012 +1200
summary:     Bug 539356 - Part 8b - Move painting of retained layers to the view manager flush, and only composite on the paint event. r=roc
(Reporter)

Updated

5 years ago
Blocks: 539356

Updated

5 years ago
Duplicate of this bug: 770040

Updated

5 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression

Updated

5 years ago
tracking-firefox16: --- → ?
Component: Tabbed Browser → Layout
Product: Firefox → Core
QA Contact: tabbed.browser → layout

Updated

5 years ago
Duplicate of this bug: 770081

Comment 3

5 years ago
More fallout from bug 539356.
Assignee: nobody → matt.woodrow
tracking-firefox16: ? → +

Comment 4

5 years ago
DLBI may not land in 16 though, so re-noming while we figure that out.
tracking-firefox16: + → ?

Comment 5

5 years ago
DLBI appears to be targeted for 17 at this point. Please set tracking-firefox16 to ? if you're still running into this on Aurora 16.
tracking-firefox16: ? → -
tracking-firefox17: --- → +

Comment 6

5 years ago
Created attachment 652098 [details]
Screenshot of DownThemAll window

This bug appeared again with the relanding of parts of DLBI. It appears that whatever is directly below the title bar is rendered incorrectly. 

I have my tabs set to be low the navigation bar and for me, the navigation bar keeps the active state while the tab bar becomes inactive.

Updated

5 years ago
Duplicate of this bug: 783191
@Matt: These "|| ![NSView focusView]" conditions are responsible for this and can be removed: http://mxr.mozilla.org/mozilla-central/search?string=![NSView+focusView]

I added them so that tab snapshots captured in inactive windows have active-looking toolbars in them, but that behavior was never very sane and can go.
(Assignee)

Comment 9

5 years ago
Created attachment 652538 [details] [diff] [review]
Remove ![NSView focusView] conditions

Any idea why my patches would have affected this?
Attachment #652538 - Flags: review?(mstange)
Comment on attachment 652538 [details] [diff] [review]
Remove ![NSView focusView] conditions

Before your patches, painting toolbars only happened inside a call to drawRect. The callers of drawRect (somewhere in Cocoa) wrap that call in [view lockFocus] / [view unlockFocus], so [NSView focusView] was non-null during painting.
Attachment #652538 - Flags: review?(mstange) → review+

Updated

5 years ago
Duplicate of this bug: 783363
Duplicate of this bug: 783664
Summary: Tab bar background does not change when window goes inactive → tab bar background does not change when window goes inactive (background/unfocused window title bars look wrong)

Updated

5 years ago
Duplicate of this bug: 783722
(Assignee)

Comment 14

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee82ab0b116

Updated

5 years ago
Duplicate of this bug: 784100
Duplicate of this bug: 784115
https://hg.mozilla.org/mozilla-central/rev/6ee82ab0b116
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
status-firefox17: --- → fixed
Keywords: verifyme
This still happens with the error console, download manager :(.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Can you file a new bug, and attach a screenshot/describe in more detail?
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Updated

5 years ago
status-firefox17: fixed → verified
Problem solved in the latest beta : Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0 , Build ID: 20121023124120.
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.