770113 - Multiple access keys used in preferences dialog for bs locale

Status: RESOLVED FIXED

(Mozilla Localizations :: bs / Bosnian, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshots

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/23e194f1171aa4baf774928b26293aa3

Details:

 accessKey: "p" found in: value: Početna stranica:, button#chooseFolder
accessKey: "b" found in: checkbox#popupPolicy, button#colors
accessKey: "i" found in: checkbox#loadImages, button[label=Izuzeci…], label[accesskey=I][control=defaultFont], button#chooseLanguage
accessKey: "e" found in: label#historyModeLabel, button#cookieExceptions
accessKey: "p" found in: checkbox#privateBrowsingAutoStart, checkbox#acceptThirdParty, button#showCookiesButton
accessKey: "e" found in: label#historyModeLabel, button#cookieExceptions
accessKey: "p" found in: checkbox#privateBrowsingAutoStart, checkbox#acceptThirdParty, button#showCookiesButton
accessKey: "u" found in: checkbox#warnAddonInstall, checkbox#useMasterPassword
accessKey: "h" found in: button[label=Pomoć], checkbox#allowHWAccel
accessKey: "p" found in: checkbox#checkSpelling, checkbox#submitTelemetryBox
accessKey: "o" found in: button#clearCacheButton, checkbox#allowSmartSize
accessKey: "a" found in: radio[label=Auto-detektuj proxy postavke za ovu mrežu], radio[label=URL za automatsko konfigurisanje proxyja:]
accessKey: "p" found in: button#showUpdateHistory, checkbox#enableSearchUpdate 

Attached you can find the screenshots of the reported failures.

Comment 1

[Kerim Kalamujic]

On it, boss ;)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The situation here has been improved a lot. Thanks Kerim. But there are still some duplicated access keys left:

http://mozmill-ci.blargon7.com/#/l10n/report/e2b510e5d4ce4614a48bf3e6fb16b5c0

accessKey: "s" found in: value: Kada se Aurora pokrene:, value: Početna stranica:
accessKey: "a" found in: checkbox#loadImages, button#advancedFonts
accessKey: "e" found in: button#popupPolicyButton, button[label=Izuzeci…]

Comment 3

[Kerim Kalamujic]

How can I find out which files I need to make these changes in? Thank you in advance.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When you see ids (marked with a '#' delimiter) you will have to query the mozilla-aurora repository via MXR:

http://mxr.mozilla.org/mozilla-aurora/search?string=popupPolicyButton

Check the element's label and access key attribute to find the right name.

Then or for labels (given via 'value') you can query the mozilla-aurora-l10n repository:

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=popupExceptions&find=/bs

Or would screenshots be more of help? I can provide those if you want.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshot

Looks good. So there is now only one issue remaining here. See the attached screenshot.

Comment 6

[Kerim Kalamujic]

Should be fixed now.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks way better. There is only one issue remaining for OS X:

http://mozmill-ci.blargon7.com/#/l10n/report/99ab6c49d005522227c5717d8a332c62

accessKey: "k" found in: label#keepUntil, button#showCookiesButton

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, which is happening for Linux as well:
http://mozmill-ci.blargon7.com/#/l10n/report/99ab6c49d005522227c5717d8a3321fa

Comment 9

[Kerim Kalamujic]

Hopefully, there will be no more wrong accesskeys :)

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks perfect now. Thanks Kerim!

Comment 11

[Kerim Kalamujic]

Thanks, Henrik. It would be mission impossible without your precious help!