Test failure 'The pane did not load in time: paneTabs ' when switching panes in preferences window

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: RemusPop)

Tracking

unspecified
All
Mac OS X

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
With the fix on bug 757340 we have introduced a new regression which is intermittent. In some cases tests fail to switch to the target pane due to a timeout in our test. We probably should increase it. How long was the waiting time before? Remus, can you please take that?

http://mozmill-ci.blargon7.com/#/l10n/report/23e194f1171aa4baf774928b2624c069
(Assignee)

Comment 1

5 years ago
We were using the default timeout (5s). So the waiting time is the same.
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
OS: All → Mac OS X
(Assignee)

Comment 2

5 years ago
The problem is that with the no animation pref of the pref pane, nodeToProcess.style.opacity == 1 will always be false.
(Reporter)

Comment 3

5 years ago
Why is that a problem? We do not rely on this CSS style in our test. Why should it then affect the waitFor() call?
(Assignee)

Comment 4

5 years ago
That line is the one that makes the waitFor pass on Mac when we the animation is on.
(Reporter)

Comment 5

5 years ago
We do not have the animation enabled! We pref it off before changing the panes. What we are waiting for is the target pane to be selected. There is no transition related code in here:

http://hg.mozilla.org/qa/mozmill-tests/file/32421e34b8d8/lib/prefs.js#l90

Please try if you can reproduce locally.
(Assignee)

Comment 6

5 years ago
I was talking about this waitFor:
http://hg.mozilla.org/qa/mozmill-tests/file/32421e34b8d8/lib/dom-utils.js#l345

Yes, I can reproduce it locally.
(Reporter)

Comment 7

5 years ago
Oh wow. Yes, those to lines have to be removed than.
(Assignee)

Comment 8

5 years ago
What 2 lines? Please check the whole condtion.
(Reporter)

Comment 9

5 years ago
(In reply to Remus Pop (:RemusPop) from comment #8)
> What 2 lines? Please check the whole condtion.

Those two lines you was talking about in comment 2. If you have problems please lets discuss this on IRC. This process here slows us down.
(Assignee)

Updated

5 years ago
status-firefox15: --- → affected
(Assignee)

Comment 10

5 years ago
Created attachment 638686 [details] [diff] [review]
patch v1 (aurora)

The style is no longer affected if we don't have animation (which is disabled in the setter of paneId BTW) so I removed it.
Attachment #638686 - Flags: review?(hskupin)
Attachment #638686 - Flags: review?(dave.hunt)
(Reporter)

Updated

5 years ago
Attachment #638686 - Flags: review?(dave.hunt)
(Reporter)

Comment 11

5 years ago
Comment on attachment 638686 [details] [diff] [review]
patch v1 (aurora)

That works. Thanks for the patch!
Attachment #638686 - Flags: review?(hskupin) → review+
(Reporter)

Comment 12

5 years ago
Given that we do not have any tests running on default only which exercise this code path, I pushed it to default and aurora:

http://hg.mozilla.org/qa/mozmill-tests/rev/a3b6cf6264c5 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/40b3a0afa3ac (aurora)

If that works I will land on the other branches soon.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: affected → fixed
status-firefox16: --- → fixed
Resolution: --- → FIXED
(Reporter)

Comment 13

5 years ago
Works fine for latest fi locale:
http://mozmill-ci.blargon7.com/#/l10n/report/4c461f9adf1253771fc6455667068493

Pushed to other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/29b29d43c658 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/9376a5d0b545 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/27b549e8598c (esr10)
status-firefox-esr10: affected → fixed
status-firefox13: affected → fixed
status-firefox14: affected → fixed
You need to log in before you can comment on or make changes to this bug.