770129 - Have appropriate buttons for each app queue

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

The app queues should have the following actions:

'Apps' Queue:

Approve - send email
Reject - send email
Request more information  - send email
Escalate App  - send notification email(??)
Comment - don't send email

'Re-review' Queue:

Approve - don't send email
Reject - send email
Request more information  - send email
Escalate App  - send notification email(??)
Comment - don't send email

'Escalations' Queue:
The actions depend on the state of the app.  If its in the 'Apps' queue then it should have the same actions as the 'Apps' queue; if its in the 'Re-review' queue then the same as that queue.  The 'Escalate App' action would be redundant but can stay if its easier. Otherwise, if its an auto-escalation (too many refunds, etc) then the following actions:

Clear Escalation - don't send email
Reject - send email
Request more information - send email
Comment - don't send email

Comment 1

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #0)
> 'Re-review' Queue:
> 
> Approve - don't send email

To me this doesn't make sense if the app is already public. I think we need a "Clear re-review" similar to "Clear escalation", where a reviewer can add a comment and remove the app from the re-review queue.  The rest make sense to me.

> If its in the 'Apps' queue then it should have the same actions as the 'Apps' queue

My understanding was that if an app was escalated, it would be removed from the other queues. Is that not true?

Comment 2

[krupa raj[:krupa]]

As far as I know, an app under review cannot be escalated since it cannot be purchased.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> (In reply to Andrew Williamson [:eviljeff] from comment #0)
> > 'Re-review' Queue:
> > 
> > Approve - don't send email
> 
> To me this doesn't make sense if the app is already public. I think we need
> a "Clear re-review" similar to "Clear escalation", where a reviewer can add
> a comment and remove the app from the re-review queue.  The rest make sense
> to me.

Yes, its the same thing.

> > If its in the 'Apps' queue then it should have the same actions as the 'Apps' queue
> 
> My understanding was that if an app was escalated, it would be removed from
> the other queues. Is that not true?

yes, it wouldn't show in the other queues.  Though the review would still need to act like it was in the other queue - i.e. if it was in the Apps (pending) queue before it was escalated then I need to be able to Approve, Reject, send info request, comment, the same as when it was in the Apps queue.

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to krupa raj 82[:krupa] from comment #2)
> As far as I know, an app under review cannot be escalated since it cannot be
> purchased.

Can you explain this? You can't purchase an app under review???  I certainly can but if 'Reviewer' users can't then its a different bug that needs to be fixed.

Comment 5

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/97e6d87

Comment 6

[Andrew Williamson [:eviljeff]]

The buttons shown for the various queues seem to be fine (I've not tested the actions for all the buttons)

Bug 775978 has already been logged to only have the disable app button for admin-like users.

Comment 7

[krupa raj[:krupa]]

The stuff I checked seemed to work fine.