duplicated DOM IDs dummycontenttoolbox and dummycontenttoolbar in specialTabs.xul

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: teramako, Assigned: teramako)

Tracking

15 Branch
Thunderbird 16.0
x86
Windows XP
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 638312 [details]
DOM Inspector: when open a tab as contentTab type, same ids are created

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901

Steps to reproduce:

in specialTabs.xul, same DOM IDs are exist.

http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#21
http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#36

- dummycontenttoolbox
- dummycontenttoolbar

And when open a tab as contentTab or chromeTab type, duplicated element's ids are created with cloneNode.




Expected results:

To be fixed,
 1. )change to dummychrometoolbox and dummychrometoolbar from dummycontenttoolbox and dummycontenttoolbar in chromeTab id's element.

 2.) change ids after cloneNode on "openTab" method each of chromeTab and contentTab.
(Assignee)

Comment 1

5 years ago
Created attachment 638322 [details] [diff] [review]
patch 1
Status: UNCONFIRMED → ASSIGNED
Component: General → Toolbars and Tabs
Ever confirmed: true
QA Contact: general → toolbars-tabs
Comment on attachment 638322 [details] [diff] [review]
patch 1

Thank you very much for the patch. In order to get things in, you'll need to set the review request to someone. Just doing this for you now.
Attachment #638322 - Flags: review?(mconley)
Assignee: nobody → teramako
Comment on attachment 638322 [details] [diff] [review]
patch 1

Review of attachment 638322 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome - thanks for the patch!
Attachment #638322 - Flags: review?(mconley) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/6446a293fb93
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.