770133 - duplicated DOM IDs dummycontenttoolbox and dummycontenttoolbar in specialTabs.xul

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[teramako]

Attachment: DOM Inspector: when open a tab as contentTab type, same ids are created

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901

Steps to reproduce:

in specialTabs.xul, same DOM IDs are exist.

http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#21
http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.xul#36

- dummycontenttoolbox
- dummycontenttoolbar

And when open a tab as contentTab or chromeTab type, duplicated element's ids are created with cloneNode.




Expected results:

To be fixed,
 1. )change to dummychrometoolbox and dummychrometoolbar from dummycontenttoolbox and dummycontenttoolbar in chromeTab id's element.

 2.) change ids after cloneNode on "openTab" method each of chromeTab and contentTab.

Comment 1

[teramako]

Attachment: patch 1

Comment 2

[Ludovic Hirlimann [:Usul]]

Comment on attachment 638322 [details] [diff] [review]
patch 1

Thank you very much for the patch. In order to get things in, you'll need to set the review request to someone. Just doing this for you now.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 638322 [details] [diff] [review]
patch 1

Review of attachment 638322 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome - thanks for the patch!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/6446a293fb93