Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Status icon in message header and chat toolbar are different

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 17.0
x86_64
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
They message header status icon and the toolbar icon is styled differently.
(Assignee)

Comment 1

5 years ago
Created attachment 638333 [details] [diff] [review]
patch to use the icons in themes instead

This uses the platform specific presence icons in themes instead.
(Assignee)

Comment 2

5 years ago
Comment on attachment 638333 [details] [diff] [review]
patch to use the icons in themes instead

Let me know if you need screenshots.
Attachment #638333 - Flags: ui-review?(mconley)
Attachment #638333 - Flags: review?(florian)
(In reply to Andreas Nilsson (:andreasn) from comment #2)
> Comment on attachment 638333 [details] [diff] [review]
> patch to use the icons in themes instead
> 
> Let me know if you need screenshots.

Yes please on the screenshots. :)
(Assignee)

Comment 4

5 years ago
Created attachment 640223 [details]
Screenshot (Linux)
Comment on attachment 638333 [details] [diff] [review]
patch to use the icons in themes instead

Applied patch looks good to me.

ui-r=me.
Attachment #638333 - Flags: ui-review?(mconley) → ui-review+
(In reply to Andreas Nilsson (:andreasn) from comment #4)
> Created attachment 640223 [details]
> Screenshot (Linux)

Andreas, is there any reason why on the "new" screenshot the icon used is the 'idle' one (the orange icon with a clock) but on the "old" screenshot it was the 'unavailable' icon (red dot)?
(Assignee)

Comment 7

5 years ago
It was because Hanne went idle during my compile :)
(In reply to Andreas Nilsson (:andreasn) from comment #7)
> It was because Hanne went idle during my compile :)

But the code uses only two icons (it used to be available.png and away.png before your changes), 'idle' isn't handled by that code.
(Assignee)

Comment 9

5 years ago
(In reply to Florian Quèze from comment #8)
> (In reply to Andreas Nilsson (:andreasn) from comment #7)
> > It was because Hanne went idle during my compile :)
> 
> But the code uses only two icons (it used to be available.png and away.png
> before your changes), 'idle' isn't handled by that code.

Crap, I think you're right. I mixed those up. I'll fix the regressions and post a new patch.
(Assignee)

Comment 10

5 years ago
Created attachment 640992 [details] [diff] [review]
patch (v2)

Carrying over ui-r+ and asking for new review.
Attachment #638333 - Attachment is obsolete: true
Attachment #640223 - Attachment is obsolete: true
Attachment #638333 - Flags: review?(florian)
Attachment #640992 - Flags: ui-review+
Attachment #640992 - Flags: review?(florian)
Attachment #640992 - Flags: review?(florian) → review+
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/a38e5c83cbfa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.