Closed Bug 770139 Opened 12 years ago Closed 12 years ago

Status icon in message header and chat toolbar are different

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 17.0

People

(Reporter: andreasn, Assigned: andreasn)

Details

Attachments

(1 file, 2 obsolete files)

patch (v2)
2.90 KB, patch
florian
: review+
andreasn
: ui-review+
Details | Diff | Splinter Review 
They message header status icon and the toolbar icon is styled differently.
This uses the platform specific presence icons in themes instead.
Comment on attachment 638333 [details] [diff] [review]
patch to use the icons in themes instead

Let me know if you need screenshots.
Attachment #638333 - Flags: ui-review?(mconley)
Attachment #638333 - Flags: review?(florian)
(In reply to Andreas Nilsson (:andreasn) from comment #2)
> Comment on attachment 638333 [details] [diff] [review]
> patch to use the icons in themes instead
> 
> Let me know if you need screenshots.

Yes please on the screenshots. :)
Attached image Screenshot (Linux) (obsolete) — 

    
    

    
  
Comment on attachment 638333 [details] [diff] [review]
patch to use the icons in themes instead

Applied patch looks good to me.

ui-r=me.

        Attachment #638333 -
        Flags: ui-review?(mconley) → ui-review+

    
    

    
  
(In reply to Andreas Nilsson (:andreasn) from comment #4)
> Created attachment 640223 [details]
> Screenshot (Linux)

Andreas, is there any reason why on the "new" screenshot the icon used is the 'idle' one (the orange icon with a clock) but on the "old" screenshot it was the 'unavailable' icon (red dot)?

    
    

    
  
It was because Hanne went idle during my compile :)

    
    

    
  
(In reply to Andreas Nilsson (:andreasn) from comment #7)
> It was because Hanne went idle during my compile :)

But the code uses only two icons (it used to be available.png and away.png before your changes), 'idle' isn't handled by that code.

    
    

    
  
(In reply to Florian Quèze from comment #8)
> (In reply to Andreas Nilsson (:andreasn) from comment #7)
> > It was because Hanne went idle during my compile :)
> 
> But the code uses only two icons (it used to be available.png and away.png
> before your changes), 'idle' isn't handled by that code.

Crap, I think you're right. I mixed those up. I'll fix the regressions and post a new patch.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (v2)
        — 
          — Splinter Review
      

    


  
Carrying over ui-r+ and asking for new review.

        Attachment #638333 -
        Attachment is obsolete: true

        Attachment #640223 -
        Attachment is obsolete: true

        Attachment #638333 -
        Flags: review?(florian)

        Attachment #640992 -
        Flags: ui-review+

        Attachment #640992 -
        Flags: review?(florian)

        Attachment #640992 -
        Flags: review?(florian) → review+
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/a38e5c83cbfa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: