Closed Bug 770165 Opened 10 years ago Closed 10 years ago

Pymake and GNU make have different inter-path separators on Windows

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: rain1, Assigned: rain1)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch workaround/fix (obsolete) — Splinter Review
For inter-path separators (the : in PATH=/bin:/usr/bin) Pymake uses the Windows standard semicolon (;) while GNU make uses the Unix standard colon (:). This means vpath-directive.mk currently fails with GNU make but succeeds with pymake.

I've attached a patch that makes the test pass, but that doesn't seem to be the right thing to do. (Or is it?)

Two questions:
1. Can this be fixed at all?
2. Should this be fixed?
Attachment #638338 - Flags: feedback?(khuey)
It would be helpful if these patches could be against the pymake repository itself instead of the mozilla repo.

It is the correct behavior for VPATH to use the ; separator on Windows, because pymake operates on native paths, while msys make on windows operates on msys paths. So changing the test is probably the correct answer. This is one of the fundamental differences between pymake and msys make. I don't think that this is a problem if we're comparing against mingw32-make, though, which also operates on windows-style paths.
> So changing the test is probably the correct answer.

Yes, that's what I first thought, but don't relative paths make this a bit murkier? So far I think we've been cheating our way into successfully building on Windows with Pymake by only using relative paths.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> pymake operates on native paths, while msys make on windows operates
> on msys paths.

Note that's what makes building nss with pymake really hard.
See Also: → 770141
See Also: 770141
Attached patch patchSplinter Review
per bsmedberg's recommendation.
Assignee: nobody → sagarwal
Attachment #638338 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #638338 - Flags: feedback?(khuey)
Attachment #645068 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/30ad537fca91
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.