Closed Bug 770182 Opened 7 years ago Closed 7 years ago
Stop preprocessing unnecessarily
Spun off from bug 758354. The preprocessor should warn when no preprocessing was done. Preprocessor.py has three entry points, do_include (used by JarMaker.py), preprocess (used by makexpi.py) and handleCommandLine (used by main). We can patch handleCommandLine to catch useless preprocessing in Makefiles. We can ignore preprocess for now because only Venkman and ChatZilla use it. We can't patch do_include because it's called recursively, and we also don't want to trip over basic jar.mn files, so we should patch JarMaker instead.
I backed this out of inbound because of make check orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/c07ade928cc0
Comment on attachment 638387 [details] [diff] [review] Possible patch Pushed mozilla-inbound changeset 13ea641e1b5a.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Differences between the builds: Linux warns for browser/themes/gnomestripe/places/organizer.xml Mac warns for browser/themes/pinstripe/preferences/in-content/preferences.css Windows warns for: browser/base/content/win6BrowserOverlay.xul browser/components/migration/src/IEProfileMigrator.js browser/themes/winstripe/searchbar.css webapprt/win/webapp-uninstaller.nsi.in Otherwise they all warn for the same 162 files.
You need to log in before you can comment on or make changes to this bug.