Status

()

Core
Build Config
6 years ago
6 years ago

People

(Reporter: gps, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
We should probably have a .gitattributes file checked in to the root directory of mozilla-central to enforce conventions.

https://www.kernel.org/pub/software/scm/git/docs/gitattributes.html

At the very least, we should probably define EOL conventions so LF is preserved everywhere (I'm pretty sure checkouts on Windows using Mercurial use LF, so we should force LF everywhere).

We could also add in default diff arguments so patches are produced with Mozilla's preferred 8 lines of context.

And, if we want to be slightly sneaky, we could probably set some whitespace config parameters so patches with trailing whitespace are treated as errors. (This is the default git behavior, but some people may have it disabled.)
CC Hal, as he is working on m-c<->github mirroring
(In reply to Justin Wood (:Callek) from comment #1)
> CC Hal, as he is working on m-c<->github mirroring

Correction: we're supporting m-c -> git read only mirroring. All changes to m-c must be landed on hg.m.o

I believe this is simply a coding style issue for the dev community to reach consensus on and implement. It should have zero impact on either the CI system or hg -> git work.
You need to log in before you can comment on or make changes to this bug.