Closed
Bug 770386
Opened 12 years ago
Closed 12 years ago
Update Metro installscript makefile so build won't fail on user accounts containing spaces
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jwilde, Unassigned)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
Details | Diff | Splinter Review |
The build currently fails if the account for the currently-logged-in user contains a space. When the user name contains a space, $(L10NBASEDIR) in browser\metro\shell\installscripts\Makefile.in has a space (but lacks quotes), messing up the arguments passed to Preprocessor.py at line 42.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → jonathan
|
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Attachment #638569 -
Flags: review?(jmathies)
|
|
Reporter | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•12 years ago
|
||
Comment on attachment 638569 [details] [diff] [review] patch v1 We currently don't use this variable in the shortcut script. So -DUSER=$(L10NBASEDIR) can be removed.
Attachment #638569 -
Flags: review?(jmathies)
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
|
|
||
Updated•12 years ago
|
Assignee: jonathan → nobody
|
Assignee | |
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
|
|
Assignee | |
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•