770391 - Fix and re-enable "Edit article based on this revision" feature

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Editing, defect, P3)

Description

[David Walsh :davidwalsh]

If you go to the history page for any document, click on the document date link, click "Edit article based on this revision", make a any change, and then save the document, the page reloads with something like the following message:

"
Edit article based on this revision
Please review the differences between your changes and the changes saved since you started editing. You may save again, but try to resolve any conflicts by hand so that the changes made since you started are not lost.
Your Changes

Revision 12 by davidwalsh on July 2, 2012 4:49:24 PM PDT
Current Revision:

Revision 18 by davidwalsh on July 2, 2012 5:48:22 PM PDT
"

If I click "Save" again, I see the same message.  Essentially, a save based on a revision will never be committed -- you simply see the message above over and over again.

Comment 1

[Les Orchard [:lorchard]]

Since we're low on time, I'm going to bounce this out of the July critical path.

Comment 2

[John Karahalis [:openjck]]

Understood. Opened bug 773921 about hiding the feature until it's fixed. Renaming this one to fix and re-enable the feature later on.

Comment 3

[John Karahalis [:openjck]]

Sheppy recently asked if we still want to do this given our new ability to revert pages.

Comment 4

[Luke Crouch [:groovecoder]]

Sheppy's supposed to *answer* those kinds of questions - not ask them. :)

Comment 5

[Jean-Yves Perrier [:teoli]]

I think we don't need that feature. Just revert then edit. That means not to show the EDIT button on old revisions pages.