Last Comment Bug 770491 - Fix leak introduced by System Message Handler API
: Fix leak introduced by System Message Handler API
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks: system-message-api
  Show dependency treegraph
 
Reported: 2012-07-03 06:45 PDT by Mounir Lamouri (:mounir)
Modified: 2012-07-03 23:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (937 bytes, patch)
2012-07-03 06:45 PDT, Mounir Lamouri (:mounir)
khuey: review+
mounir: checkin+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2012-07-03 06:45:59 PDT
Created attachment 638691 [details] [diff] [review]
Patch
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-03 06:47:26 PDT
Comment on attachment 638691 [details] [diff] [review]
Patch

Review of attachment 638691 [details] [diff] [review]:
-----------------------------------------------------------------

Really need tests that exercise this code ...
Comment 2 Mounir Lamouri (:mounir) 2012-07-03 06:51:06 PDT
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #1)
> Comment on attachment 638691 [details] [diff] [review]
> Patch
> 
> Review of attachment 638691 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Really need tests that exercise this code ...

Indeed. I've heard there are plans for System Message Handler tests.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-03 16:08:07 PDT
https://hg.mozilla.org/mozilla-central/rev/7ae505066ea7

Note You need to log in before you can comment on or make changes to this bug.