Closed Bug 770491 Opened 9 years ago Closed 9 years ago

Fix leak introduced by System Message Handler API

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #638691 - Flags: review?(khuey)
Comment on attachment 638691 [details] [diff] [review]
Patch

Review of attachment 638691 [details] [diff] [review]:
-----------------------------------------------------------------

Really need tests that exercise this code ...
Attachment #638691 - Flags: review?(khuey) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #1)
> Comment on attachment 638691 [details] [diff] [review]
> Patch
> 
> Review of attachment 638691 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Really need tests that exercise this code ...

Indeed. I've heard there are plans for System Message Handler tests.
Target Milestone: --- → mozilla16
Attachment #638691 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/7ae505066ea7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.