770543 - Multiple access keys used in preferences dialog for fi locale

Status: RESOLVED FIXED

(Mozilla Localizations :: fi / Finnish, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshots

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/4c461f9adf1253771fc6455667066c81

Details:

 accessKey: "i" found in: button[label=Poikkeukset…], button#advancedJSButton
accessKey: "k" found in: value: Koko:, value: Koko:
accessKey: "e" found in: checkbox#rememberHistory, label#locationBarSuggestionLabel
accessKey: "k" found in: button#cookieExceptions, checkbox#alwaysClear
accessKey: "o" found in: button[label=Ohje], checkbox#rememberForms
accessKey: "h" found in: radio[label=Hae päivityksiä, mutta minä päätän asennetaanko ne], checkbox#enableSearchUpdate

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshots

Screenshots for Linux are better than Mac because those show the access key underlined.

Comment 3

[Ville Pohjanheimo (inactive)]

Thanks. Fixed on aurora.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, but the latest testrun still shows problems:
http://mozmill-ci.blargon7.com/#/l10n/report/4c461f9adf1253771fc645566720ee61

accessKey: "k" found in: value: Koko:, value: Koko:
accessKey: "a" found in: radio[label=Asenna automaattisesti (suositeltu: turvallisin)], checkbox#enableSearchUpdate 

Whenever you check-in changes you can have a look at the following URL a couple of minutes later for results:

http://mozmill-ci.blargon7.com/#/l10n/reports

Comment 5

[Ville Pohjanheimo (inactive)]

Doh. Too tired apparently to miss the latter one listed. Fixed now.

The k-accesskey bug is a wontfix. I'd rather always and everywhere have the same accesskey for Help than fix this minor bug. Therefore this bug closed as wontfix. (However thank you very much again for these helpful bugs/reports. They are a great help in making a good l10n).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Ville Pohjanheimo from comment #5)
> The k-accesskey bug is a wontfix. I'd rather always and everywhere have the
> same accesskey for Help than fix this minor bug. Therefore this bug closed
> as wontfix. (However thank you very much again for these helpful
> bugs/reports. They are a great help in making a good l10n).

Well, it's not that easy. We can't simply close it as wontfix because it would invalidate our mozmill tests. We can't exclude single access keys. Right now I'm not sure how this could be fixed. I will CC Axel so that he can give feedback. Also I will attach a single screenshot so it's better visible what's going on here.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: remaining access key conflict

Comment 8

[Axel Hecht [:Pike]]

Yeah, this seems to be "size" vs "size", and you'll need to use an off accesskey for one there, otherwise the UI is just not accessible in one of the two.

Comment 9

[Ville Pohjanheimo (inactive)]

Fixed in http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/ffacfabdc11c