[shipping] show currently accepted/pending/rejected signoffs post last milestone

RESOLVED FIXED in 2.3

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Right now, if there are no shipped milestones yet, locale-changes like https://l10n.mozilla.org/shipping/app/locale-changes/fx15 looks as if there wasn't any traction on 15 yet.

It should show something, though, and it'd be good to not just show accepted, but also pending and rejected, as there's at least some sign of traction on those.
(Assignee)

Comment 1

6 years ago
Created attachment 639066 [details] [diff] [review]
rewrite fallback logic a bit, and add another row for changes that are coming after the last milestone

While trying to find the right way to keep the upcoming data from the top of the code to the bottom, I realized that I wrote the fallback code a tad too complicated, IMHO. So I changed that.

Given that we're seeing pending sign-offs on that page now, I went ahead and turned the locale names into links to the sign-off pages. I'm always using the currently viewed appver, not the fallback ones, as for locales that started working again, that's the more useful link. For locales that didn't, we need to cross link from the current sign-off page to ones that date back anyway, I think.

No change in poor test-coverage for this one.
Attachment #639066 - Flags: review?(peterbe)
Comment on attachment 639066 [details] [diff] [review]
rewrite fallback logic a bit, and add another row for changes that are coming after the last milestone

Review of attachment 639066 [details] [diff] [review]:
-----------------------------------------------------------------

A quick check.py run should spot some silly nits.

::: apps/shipping/views/app.py
@@ +33,4 @@
>      # get historic data that enters this appversion
>      # get that in fallback order, we'll reverse afterwards
>      flags4av = flags4appversions(appversions={"id": av.id})
> +    flags4loc=flags4av[av]

pep8 :(

@@ +110,3 @@
>          # previous milestone has locales left, update previous changes
>          changes += [(loc, 'dropped') for loc in latest.iterkeys()]
>          changes.sort(key=lambda t: t[0])

isn't that lambda the default sort function?
Attachment #639066 - Flags: review?(peterbe) → review+

Comment 3

6 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/faa12f5dc9a03b293cb2da1ad30174e6cf42993c
bug 770547, add changes after the last milestone, and link to sign-off pages, r=peterbe
(Assignee)

Comment 4

6 years ago
I fixed the review nits, and landed and deployed on dev, marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.3
Version: Trunk → 2.3
You need to log in before you can comment on or make changes to this bug.