770664 - [pa-IN] Incorrectly landed search engines for Thunderbird

Status: RESOLVED WORKSFORME

(Mozilla Localizations :: pa-IN / Punjabi, defect)

Description

[Mark Banner (:standard8)]

I've rejected your latest sign-off on the beta channel as you've pushed search engines for Thunderbird without prior approval. Any changes to mail/searchplugins/ need review first.

However, in this instance, I'm fine with the list.txt addition as that matches en-US.

You need to hg remove the rest of the files in that directory:

mail/searchplugins/amazondotcom.xml
mail/searchplugins/aol-web-search.xml
mail/searchplugins/bing.xml
mail/searchplugins/eBay.xml
mail/searchplugins/google.xml
mail/searchplugins/twitter.xml
mail/searchplugins/wikipedia.xml
mail/searchplugins/yahoo.xml

and then commit the changes.

Please do that in all the repositories you're operating in, which I think includes central and, of course, aurora and beta.

With those removed, the build system will automatically pick up the en-US versions and any changes to them (for example, bing.xml is already different in en-US, which is why I definitely can't accept the sign-off).

If once you've corrected the issues you want to add Punjabi specific engines, we can look at that in bug 718607.


Note that your changes do include quite a lot of English strings, especially to the cloudFile/bigFile and chat additions, however I'm prepared to accept those for this release due to the translations of the message headers which will be a front-end improvement for you users.

Once you've removed the extra search-engine files, please sign-off again asap.

Comment 1

[A S Alam]

it is already fixed and not VAILD anymore. Please close when fixed if opened.