77069 - nsIHTMLContent.h should be moved to mozilla/content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The file nsIHTMLContent should live somewhere in the mozilla/content tree
instead of in mozilla/layout as now. First of all it seems like it belongs in
content rather then layout. Second, the current position screws up
http://unstable.elemental.com/mozilla

Will attach a patch that moves nsIHTMLContent.h to
mozilla/content/html/content/public which shouldn't screw up any dependencies or
makefiles since nsIHTMLContent inherits nsIXMLContent which already is in the
content tree. I did a clobber rebuild just to be sure...

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix makefiles

Comment 2

[Stephen Walker]

*** Bug 77070 has been marked as a duplicate of this bug. ***

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Just to clarify: I am by no means sure that sure that the makefile fu is
correct. I've tried to understand how the dependencies and includepaths work in
the makefiles but I just don't grok it :(. I don't seem to have the include
paths in mozilla/dist that are added, and I can't find where the includepaths
that I have actually are added :(

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

The makefile changes are correct, r=heikki. In addition to these, you must of
course copy the file into the new location and do cvs remove in the old location
and cvs add in the new location. If you have cvs access you can actually do this
(without committing!) and do cvs diff -uN (notice the 'N') which will show
removed/added files as well.

The includepaths etc. are really simple on Windows - we basically have just
dist\include. That is the normal Unix build as well. On Mac, and "Unix
dependencies check build" (or whatever it is called) the exported files are
placed in dist/include/$(MODULE) where the MODULE is specified in the makefiles.
Then you will also need REQUIRES in the Unix makefiles for that include dir in
places that use it.

Anyway, if you can do clobber build after a build change like this, I'd say you
have over 90% chance of the change being correct.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't have cvs access yet, sorry :(

Hmm.. while I'm at it, is there any more files that should be moved? It would 
be really nice if we could use the documentation on the elemental site...

Comment 6

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I know of no other such files, although there could be others.

And no problem about the lack of CVS access, if you can't make cvs show
added/removed files you can describe those changes in prose (like here) and if
you are creating totally new files you can attach those separately.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I havn't created or deleted any files. The only thing that needs to be done is
to move nsIHTMLContent.h from

mozilla/layout/html/base/src
to
mozilla/content/html/content/public

will go look for sr=

Comment 8

[Johnny Stenback (:jst)]

You have two options here, either ask [e-mail] to copy nsIHTMLContent in
the cvs repository to the new place, or to go ahead and cvs add a new copy of
the same file in the new place. The former would keep the cvs history with the
file in the new place, I'd suggest you do the former (if you can get leaf to
copy the file), but I'd be ok with this change either way.

sr=jst for the build system changes.

Comment 9

[John Keiser (jkeiser)]

*** Bug 158762 has been marked as a duplicate of this bug. ***

Comment 10

[John Keiser (jkeiser)]

Attachment: Updated makefiles patch

From the recently-duped bug

Comment 11

[John Keiser (jkeiser)]

Taking so I don't lose track :)

Comment 12

[John Keiser (jkeiser)]

Comment on attachment 92479 [details] [diff] [review]
Updated makefiles patch

Carrying r=heikki, sr=jst

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 92479 [details] [diff] [review]
Updated makefiles patch

a=asa (on behalf of drivers) for checkin to 1.1

Comment 14

[John Keiser (jkeiser)]

Checked in.