770699 - [traceback] MemcachedKeyCharacterError: Control characters not allowed

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect, P1)

Description

[raymond [:retornam] (inactive)]

Traceback (most recent call last):

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django-waffle/waffle/decorators.py", line 20, in _wrapped_view
    return view(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/views/decorators/http.py", line 37, in inner
    return func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/views.py", line 158, in process
    return func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/views/decorators/http.py", line 124, in inner
    response = func(request, *args, **kwargs)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/db/transaction.py", line 271, in _autocommit
    return func(*args, **kw)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/views.py", line 395, in document
    response = jingo.render(request, 'wiki/document.html', data)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/jingo/jingo/__init__.py", line 78, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/developer.mozilla.org/kuma/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
    return template.render(**get_context())

  File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/templates/wiki/document.html", line 15, in top-level template code
    {% set help_link = url('wiki.translate', document_path=document.parent.full_path, locale=document.parent.locale)|urlparams(tolocale=request.locale) %}

  File "/data/www/developer.mozilla.org/kuma/apps/wiki/templates/wiki/base.html", line 17, in top-level template code
    {% set scripts = ('wiki',) %}

  File "/data/www/developer.mozilla.org/kuma/templates/base.html", line 180, in top-level template code
    {% trans copyright_url=devmo_url(_('/Project:Copyrights')) %}

  File "/data/www/developer.mozilla.org/kuma/apps/devmo/helpers.py", line 83, in devmo_url
    url = cache.get('devmo_url:%s_%s' % (locale, path))

  File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/core/cache/backends/memcached.py", line 48, in get
    val = self._cache.get(smart_str(key))

  File "/data/www/developer.mozilla.org/kuma/vendor/packages/python-memcached/memcache.py", line 779, in get
    return self._get('get', key)

  File "/data/www/developer.mozilla.org/kuma/vendor/packages/python-memcached/memcache.py", line 747, in _get
    self.check_key(key)

  File "/data/www/developer.mozilla.org/kuma/vendor/packages/python-memcached/memcache.py", line 944, in check_key
    "Control characters not allowed")

MemcachedKeyCharacterError: Control characters not allowed

Comment 1

[John Karahalis [:openjck]]

Thanks for reporting this, Raymond. Do we know if users are visibly affected by this issue?

Comment 2

[Les Orchard [:lorchard]]

This is the same bug we've been seeing with incorrectly-localized devmo_url() calls in templates. I believe it was fixed here:

https://github.com/groovecoder/kuma/commit/2fd6b18a07511597485ded3d501c246a252017bd