If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Throw a warning when app name is too long for Gaia

RESOLVED FIXED in 2012-07-05

Status

Marketplace
Validation
P5
enhancement
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: cvan, Assigned: basta)

Tracking

2012-07-05
Points:
---

Details

(Reporter)

Description

5 years ago
We limit app names to 128 characters on Marketplace. And developers specify long names in their manifests so when users go to install the app and launch it from their B2G phones, the name gets truncated.

If the "name" is longer than 9 characters (I think that's about the max), throw a warning telling them it will be truncated when natively installed.
(Reporter)

Updated

5 years ago
Summary: Throw a warning when app name is too long → Throw a warning when app name is too long for Gaia
(Assignee)

Comment 1

5 years ago
Done:

https://github.com/mozilla/amo-validator/pull/167/files
Isn't this fixed? I saw this working on the marketplace prod just now doing a test.
(Assignee)

Comment 3

5 years ago
Ah yes. Whoever closed the pull request didn't close the bug.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

5 years ago
See https://github.com/mozilla/amo-validator/pull/167/files#r1199160
(Reporter)

Updated

5 years ago
Assignee: nobody → mattbasta
Target Milestone: --- → 2012-07-05
(Assignee)

Comment 5

5 years ago
Updated
The current checks, just look at the name attribute, not at the localized name...

(Meta: Should I look at the app-validator or at the amo-validator repo?)
(Assignee)

Comment 7

5 years ago
Here's the code that performs the check:

https://github.com/mozilla/app-validator/blob/master/appvalidator/webapp.py#L38
So this code is just looking at name but not at the localized names.
I wonder if it should iterate through all given in the locales dict and check the names in there too.
(Assignee)

Updated

4 years ago
Blocks: 870393
(Assignee)

Comment 9

4 years ago
I've filed bug 870393 to fix that issue.
You need to log in before you can comment on or make changes to this bug.