Closed
Bug 770792
Opened 12 years ago
Closed 12 years ago
PRIORITY_CRITICAL_HIGH notification bar on Windows and Linux is ugly solid red
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(2 files)
|
475.46 KB,
image/png
|
Details | |
|
1.45 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Screenshot of bug
The Mac OS X implementation of PRIORITY_CRITICAL_HIGH notification bars have a nice red gradient that is missing on Windows. See attached screenshot for comparison.
|
Assignee | |
Updated•12 years ago
|
Summary: PRIORITY_CRITICAL_HIGH notification bar on Windows is ugly solid red → PRIORITY_CRITICAL_HIGH notification bar on Windows and Linux is ugly solid red
|
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
This patch uses the same colors found in the gradient for pinstripe.
Attachment #638985 -
Attachment is patch: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #638985 -
Flags: review?(paul)
|
||
Updated•12 years ago
|
Severity: normal → trivial
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 638985 [details] [diff] [review] Patch There's no good reason for using rgba here. It should be an rgb value, and for now you can just keep the plain white. r=me with that
Attachment #638985 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Changed to use color:white and pushed to inbound: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=3e206a3aa14e
Flags: in-testsuite-
Target Milestone: --- → mozilla16
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3e206a3aa14e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•