Merge nsIEditorSupport into nsEditor

RESOLVED FIXED in mozilla16

Status

()

Core
Editor
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: sankha)

Tracking

({dev-doc-needed})

Trunk
mozilla16
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=ehsan][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

The file editor/libeditor/base/nsIEditorSupport.h is unnecessary.  Nothing uses the interface, and the only thing that's derived from it is editor/libeditor/base/nsEditor.h.  It should be merged into nsEditor and deleted.

(See bug 769967 comment 8.)
Whiteboard: [mentor=ehsan] → [mentor=ehsan][lang=c++]
(Assignee)

Comment 1

5 years ago
Can you assign me the bug? I would like to work on it.
Sure!
Assignee: nobody → sankha93
(Assignee)

Comment 3

5 years ago
Created attachment 640984 [details] [diff] [review]
merged nsIEditorSupport into nsEditor
Attachment #640984 - Flags: review?(ehsan)
Keywords: dev-doc-needed
Comment on attachment 640984 [details] [diff] [review]
merged nsIEditorSupport into nsEditor

Review of attachment 640984 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/nsEditor.h
@@ +8,5 @@
>  
>  #include "nsCOMPtr.h"
>  #include "nsWeakReference.h"
>  
> +#include "nsISupports.h"

This shouldn't be needed, there are tons of other headers including this one.

@@ +76,5 @@
> +
> +/**
> + * Private Editor interface for a class that can provide helper functions
> + */
> +class nsIEditorSupport  : public nsISupports {

Hmm, I think I wasn't quite clear on what I would like us to achieve in this bug.  nsIEditorSupport is a completely useless interface, and we should remove it completely.

So after taking a closer look, it turns out that nothing in mozilla-central even #includes this header, so you can just remove that header, and that would be all that needs to be done in this bug!  :-)
Attachment #640984 - Flags: review?(ehsan)
(Assignee)

Comment 5

5 years ago
Created attachment 641073 [details] [diff] [review]
Patch to just delete the nsIEditorSupport interface
Attachment #640984 - Attachment is obsolete: true
Attachment #641073 - Flags: review?(ehsan)
Comment on attachment 641073 [details] [diff] [review]
Patch to just delete the nsIEditorSupport interface

Super!
Attachment #641073 - Flags: review?(ehsan) → review+
Landed with a proper commit message, thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd0f3b5283d4
Target Milestone: --- → mozilla16

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fd0f3b5283d4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.