Closed Bug 770850 Opened 9 years ago Closed 9 years ago

DOH! DefnOrHeader should be called DefinitionList

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

ParseMaps.h is a big improvement over the prior situation, but parts of its implementation are pretty baffling. In particular, there's a nicer way to express what DefnOrHeader is doing.
Attached patch v1Splinter Review
Assignee: general → jorendorff
Attachment #639063 - Flags: review?(n.nethercote)
Handy cheat sheet:

DefnOrHeader --> DefinitionList
AtomDeclNode --> DefinitionList::Node
MultiDeclRange --> DefinitionList::Range
doh.isHeader() --> dlist.isMultiple()
AtomDOHMap --> AtomDefnListMap
Attachment #639063 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/79672ac5f11b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.