Closed
Bug 770850
Opened 13 years ago
Closed 13 years ago
DOH! DefnOrHeader should be called DefinitionList
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
30.62 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
ParseMaps.h is a big improvement over the prior situation, but parts of its implementation are pretty baffling. In particular, there's a nicer way to express what DefnOrHeader is doing.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → jorendorff
Attachment #639063 -
Flags: review?(n.nethercote)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Handy cheat sheet:
DefnOrHeader --> DefinitionList
AtomDeclNode --> DefinitionList::Node
MultiDeclRange --> DefinitionList::Range
doh.isHeader() --> dlist.isMultiple()
AtomDOHMap --> AtomDefnListMap
|
|
||
Updated•13 years ago
|
Attachment #639063 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•