Last Comment Bug 770850 - DOH! DefnOrHeader should be called DefinitionList
: DOH! DefnOrHeader should be called DefinitionList
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jason Orendorff [:jorendorff]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-04 05:28 PDT by Jason Orendorff [:jorendorff]
Modified: 2012-07-07 12:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (30.62 KB, patch)
2012-07-04 05:37 PDT, Jason Orendorff [:jorendorff]
n.nethercote: review+
Details | Diff | Splinter Review

Description Jason Orendorff [:jorendorff] 2012-07-04 05:28:13 PDT
ParseMaps.h is a big improvement over the prior situation, but parts of its implementation are pretty baffling. In particular, there's a nicer way to express what DefnOrHeader is doing.
Comment 1 Jason Orendorff [:jorendorff] 2012-07-04 05:37:27 PDT
Created attachment 639063 [details] [diff] [review]
v1
Comment 2 Jason Orendorff [:jorendorff] 2012-07-04 06:11:00 PDT
Handy cheat sheet:

DefnOrHeader --> DefinitionList
AtomDeclNode --> DefinitionList::Node
MultiDeclRange --> DefinitionList::Range
doh.isHeader() --> dlist.isMultiple()
AtomDOHMap --> AtomDefnListMap
Comment 3 Jason Orendorff [:jorendorff] 2012-07-06 14:39:28 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/79672ac5f11b
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-07 12:01:39 PDT
https://hg.mozilla.org/mozilla-central/rev/79672ac5f11b

Note You need to log in before you can comment on or make changes to this bug.