DOH! DefnOrHeader should be called DefinitionList

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
ParseMaps.h is a big improvement over the prior situation, but parts of its implementation are pretty baffling. In particular, there's a nicer way to express what DefnOrHeader is doing.
(Assignee)

Comment 1

5 years ago
Created attachment 639063 [details] [diff] [review]
v1
Assignee: general → jorendorff
Attachment #639063 - Flags: review?(n.nethercote)
(Assignee)

Comment 2

5 years ago
Handy cheat sheet:

DefnOrHeader --> DefinitionList
AtomDeclNode --> DefinitionList::Node
MultiDeclRange --> DefinitionList::Range
doh.isHeader() --> dlist.isMultiple()
AtomDOHMap --> AtomDefnListMap
Attachment #639063 - Flags: review?(n.nethercote) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/79672ac5f11b
https://hg.mozilla.org/mozilla-central/rev/79672ac5f11b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.