Last Comment Bug 770854 - Put frontend code in the frontend namespace
: Put frontend code in the frontend namespace
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jason Orendorff [:jorendorff]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-04 05:39 PDT by Jason Orendorff [:jorendorff]
Modified: 2012-07-20 06:43 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (44.40 KB, patch)
2012-07-04 06:09 PDT, Jason Orendorff [:jorendorff]
n.nethercote: review+
Details | Diff | Splinter Review

Description Jason Orendorff [:jorendorff] 2012-07-04 05:39:25 PDT

    
Comment 1 Jason Orendorff [:jorendorff] 2012-07-04 06:09:06 PDT
Created attachment 639071 [details] [diff] [review]
v1

Most of the lines in this patch are like,

>+namespace frontend {
[...]
>-namespace frontend {
Comment 2 Nicholas Nethercote [:njn] 2012-07-04 16:45:59 PDT
Comment on attachment 639071 [details] [diff] [review]
v1

Review of attachment 639071 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/SemanticAnalysis.h
@@ +19,2 @@
>  /*
> + * For each function in the compilation unit given by sc and functionList,

This sentence confuses me.  Presumably the "given by" refers to "each function" not "the compilation unit"?

Also, "given by parser->tc->sc and parser->tc->functionList" would be clearer.

Now that I look at it, AnalyzeFunctions() could be passed |parser->tc| instead of |parser|.  Can you do that?  And then you can revert the comment to what it was previously :)

::: js/src/jsprvtd.h
@@ +180,5 @@
> +namespace frontend {
> +
> +struct BytecodeEmitter;
> +struct Definition;
> +struct FunctionBox;

I've never understood the purpose of jsprvtd.h...
Comment 3 Jason Orendorff [:jorendorff] 2012-07-19 03:51:25 PDT
I've been trying to land this for days now.

The latest Try attempt:
  https://tbpl.mozilla.org/?tree=Try&rev=f6c508462c52

As you can see, loading 9%.
Comment 4 Ed Morley [:emorley] 2012-07-20 06:43:49 PDT
https://hg.mozilla.org/mozilla-central/rev/b7a08f973328

Note You need to log in before you can comment on or make changes to this bug.