Put frontend code in the frontend namespace

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 639071 [details] [diff] [review]
v1

Most of the lines in this patch are like,

>+namespace frontend {
[...]
>-namespace frontend {
Assignee: general → jorendorff
Attachment #639071 - Flags: review?(n.nethercote)
Comment on attachment 639071 [details] [diff] [review]
v1

Review of attachment 639071 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/SemanticAnalysis.h
@@ +19,2 @@
>  /*
> + * For each function in the compilation unit given by sc and functionList,

This sentence confuses me.  Presumably the "given by" refers to "each function" not "the compilation unit"?

Also, "given by parser->tc->sc and parser->tc->functionList" would be clearer.

Now that I look at it, AnalyzeFunctions() could be passed |parser->tc| instead of |parser|.  Can you do that?  And then you can revert the comment to what it was previously :)

::: js/src/jsprvtd.h
@@ +180,5 @@
> +namespace frontend {
> +
> +struct BytecodeEmitter;
> +struct Definition;
> +struct FunctionBox;

I've never understood the purpose of jsprvtd.h...
Attachment #639071 - Flags: review?(n.nethercote) → review+
Whiteboard: [js:t]
(Assignee)

Comment 3

5 years ago
I've been trying to land this for days now.

The latest Try attempt:
  https://tbpl.mozilla.org/?tree=Try&rev=f6c508462c52

As you can see, loading 9%.
https://hg.mozilla.org/mozilla-central/rev/b7a08f973328
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.