770891 - mozhttpd proxy test needs to uninstall url openers after use

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

The mozhttpd api proxy test installs a custom url opener for urllib2 globally, but doesn't reset it to default after it's finished. This causes problems if another test uses urllib2 to open a url later.

Comment 1

[William Lachance (:wlach)]

Attachment: Patch to reset global url opener to default in mozhttpd proxy api test after finished

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 639096 [details] [diff] [review]
Patch to reset global url opener to default in mozhttpd proxy api test after finished

Cool, though if this test asserts the old opener won't be reinstalled. Do you think it's worth putting it into its own class with setUp() and tearDown() methods to handler the openers (the latter being called regardless of whether the test passes or fails)?

Comment 3

[Mark Côté [:mcote]]

Also, I think

  urllib2.install_opener(urllib2.build_opener(urllib2.ProxyHandler())

should really be

  urllib2.install_opener(urllib2.build_opener())

This is what urllib2.urlopen() does if there is no opener.

Or really, maybe it should just be 

  urllib2.install_opener(None)

which would make the next call to urlopen install the default opener. I'm sure this is unlikely to change in Python 2, but it seems safer.

Comment 4

[William Lachance (:wlach)]

Attachment: Patch incorporating mcote's suggestions

Updated patch, carrying over r+

Comment 5

[William Lachance (:wlach)]

Attachment: Patch incorporating mcote's suggestions (take 2)

Oops, screwed up my diff. Here's the right patch.

Comment 6

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/mozbase/commit/434d71716bc8056bf7245c231d340ab853908d0a