Closed Bug 770938 Opened 7 years ago Closed 6 years ago

fix toolkit/components/ctypes/test/Makefile.in mochitest-chrome test path

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: froydnj, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The aforementioned file has this:

chrometestdir = \
  $(DEPTH)/_tests/testing/mochitest/chrome/toolkit/components/$(relativesrcdir)

But of course we have:

relativesrcdir = toolkit/components/ctypes/tests

So we wind up with toolkit/components/toolkit/components...  This inhibits a transition to MOCHITEST_*_FILES variables (bug 370750) for this Makefile.

We'd be changing test paths if we sanitized chrometestdir, but maybe that's not such a big deal...
Blocks: 920185
Attached patch fix ctypes test junk (obsolete) — Splinter Review
This patch cleans this up significantly, leaving only the "copy the shared library to the test directories" bits. In case you were wondering, the chrome/libraries copy is vestigal, it just didn't get removed when bug 711838 removed the rest of the jetpack process support.

I had to move the mochitest-chrome tests to a subdir to get everything to work properly, but I think it's fine. These tests all pass locally. The changes to the tests were necessary because I wanted to stop preprocessing it, but the xpcshell test also runs in a ChromeWorker, and it doesn't have access to XPCOM there, so I had to pass nsIXULRuntime.OS in from the main thread.
Attachment #8383616 - Flags: review?(gps)
Assignee: nobody → ted
Status: NEW → ASSIGNED
Oops, forgot to hg add the new manifest.
Attachment #8383771 - Flags: review?(gps)
Attachment #8383616 - Attachment is obsolete: true
Attachment #8383616 - Flags: review?(gps)
Comment on attachment 8383771 [details] [diff] [review]
fix ctypes test junk

Review of attachment 8383771 [details] [diff] [review]:
-----------------------------------------------------------------

Land it!

::: toolkit/components/ctypes/tests/Makefile.in
@@ -3,5 @@
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  EXTRA_DSO_LDOPTS += $(MOZALLOC_LIB)
>  
> -xpctestdir = $(testxpcobjdir)/$(relativesrcdir)/unit

Wait, $(testxpcobjdir) still exists?!
Attachment #8383771 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/e9aafdc00b47
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.