Closed Bug 770938 Opened 7 years ago Closed 6 years ago
.in mochitest-chrome test path
The aforementioned file has this: chrometestdir = \ $(DEPTH)/_tests/testing/mochitest/chrome/toolkit/components/$(relativesrcdir) But of course we have: relativesrcdir = toolkit/components/ctypes/tests So we wind up with toolkit/components/toolkit/components... This inhibits a transition to MOCHITEST_*_FILES variables (bug 370750) for this Makefile. We'd be changing test paths if we sanitized chrometestdir, but maybe that's not such a big deal...
This patch cleans this up significantly, leaving only the "copy the shared library to the test directories" bits. In case you were wondering, the chrome/libraries copy is vestigal, it just didn't get removed when bug 711838 removed the rest of the jetpack process support. I had to move the mochitest-chrome tests to a subdir to get everything to work properly, but I think it's fine. These tests all pass locally. The changes to the tests were necessary because I wanted to stop preprocessing it, but the xpcshell test also runs in a ChromeWorker, and it doesn't have access to XPCOM there, so I had to pass nsIXULRuntime.OS in from the main thread.
Assignee: nobody → ted
Status: NEW → ASSIGNED
Oops, forgot to hg add the new manifest.
Attachment #8383771 - Flags: review?(gps)
Comment on attachment 8383771 [details] [diff] [review] fix ctypes test junk Review of attachment 8383771 [details] [diff] [review]: ----------------------------------------------------------------- Land it! ::: toolkit/components/ctypes/tests/Makefile.in @@ -3,5 @@ > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > EXTRA_DSO_LDOPTS += $(MOZALLOC_LIB) > > -xpctestdir = $(testxpcobjdir)/$(relativesrcdir)/unit Wait, $(testxpcobjdir) still exists?!
Attachment #8383771 - Flags: review?(gps) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.