Closed Bug 771053 Opened 10 years ago Closed 10 years ago

Remove --with-endian from buildbot-configs' mozconfigs

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch configs v1Splinter Review
In bug 538524 comment 3, Vlad said to use "ac_add_options --with-endian=little", a couple of weeks after Ted had said that configure option would be added over his dead body. Ted's still alive, and it wasn't ever added outside of Vlad's user repo.

Since then, there's been rather a lot of copy-paste.

I've never bothered to look at what people are talking about when they talk about release-sanity comparing mozconfigs, so I don't know whether (the release) parts of this are a necessary followup to bug 766560, or it's all just for fun, but my experience with trying to stamp out copy-paste infections is that you want to remove absolutely every single one, used or unused, or a couple of weeks later someone will find the single abandoned one you didn't remove and copy it.
Attachment #639236 - Flags: review?(bear)
Oh, release-sanity just compares the nightly and release mozconfigs, doesn't it? Whew, since if it was comparing in-tree and out-of-tree I'd have to jump down the trains with the in-tree ones.
Comment on attachment 639236 [details] [diff] [review]
configs v1

:( wrong time to miss a review for such a simple change...

apologies
Attachment #639236 - Flags: review?(bear) → review+
In production.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.