Closed
Bug 771053
Opened 12 years ago
Closed 12 years ago
Remove --with-endian from buildbot-configs' mozconfigs
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
References
Details
Attachments
(1 file)
61.80 KB,
patch
|
bear
:
review+
philor
:
checked-in+
|
Details | Diff | Splinter Review |
In bug 538524 comment 3, Vlad said to use "ac_add_options --with-endian=little", a couple of weeks after Ted had said that configure option would be added over his dead body. Ted's still alive, and it wasn't ever added outside of Vlad's user repo. Since then, there's been rather a lot of copy-paste. I've never bothered to look at what people are talking about when they talk about release-sanity comparing mozconfigs, so I don't know whether (the release) parts of this are a necessary followup to bug 766560, or it's all just for fun, but my experience with trying to stamp out copy-paste infections is that you want to remove absolutely every single one, used or unused, or a couple of weeks later someone will find the single abandoned one you didn't remove and copy it.
Attachment #639236 -
Flags: review?(bear)
Assignee | ||
Comment 1•12 years ago
|
||
Oh, release-sanity just compares the nightly and release mozconfigs, doesn't it? Whew, since if it was comparing in-tree and out-of-tree I'd have to jump down the trains with the in-tree ones.
Comment 2•12 years ago
|
||
Comment on attachment 639236 [details] [diff] [review] configs v1 :( wrong time to miss a review for such a simple change... apologies
Attachment #639236 -
Flags: review?(bear) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 639236 [details] [diff] [review] configs v1 http://hg.mozilla.org/build/buildbot-configs/rev/53e838961fa7
Attachment #639236 -
Flags: checked-in+
Comment 4•12 years ago
|
||
In production.
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•