771063 - [IE9] Unable to get value of the property 'visible': object is null or undefined @ impala-min.js?build=78073c4, line 8 character 28477

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect)

Description

[James Ross]

When loading an AMO statistics page, such as https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/statistics/, the following error is logged and the statistics fail to load:

SCRIPT5007: Unable to get value of the property 'visible': object is null or undefined 
impala-min.js?build=78073c4, line 8 character 28477

This is caused by an assumption that 'window.locationbar' exists - it does not in IE or Opera. The following part of impala-min.js:

    chromeless:!window.locationbar.visible,

Can be changed to:

    chromeless:window.locationbar&&!window.locationbar.visible,

And the page loads fine with all statistics.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/249de31

This will go live with our push today at 2:00 PM PDT. Thanks for filing!

Comment 2

[Aditya Jalgaonkar [:Adi_J]]

Verified the and bug seems to be fixed.

Comment 3

[James Ross]

Not sure why this got verified ahead of time as it's well past 2PM PDT but there's no sign of this on live. When should I expect it to be live instead?

Comment 4

[Aditya Jalgaonkar [:Adi_J]]

Sorry, tested it on the wrong platform, my apologies, Verified that the bug still exists:

http://screencast.com/t/qMAcT0BLcwT

Comment 5

[James Ross]

Things appear to have made it to live (at least the URL in comment 0).

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to James Ross from comment #5)
> Things appear to have made it to live (at least the URL in comment 0).

Yeah, the original error you spotted has been fixed. But now we have a new one:

    Unable to set value of the property 'messages': object is null or undefined

I filed a new bug (bug 771558) to more easily track this. Sorry for all the confusion above, and thanks for filing.