Closed Bug 771085 Opened 8 years ago Closed 8 years ago

Define MOZ_APP_BASENAME for Thunderbird to help fix Permanent orange: TEST-UNEXPECTED-FAIL | test_0200_app_launch_apply_update.js failures (and test_0201..., test_0203...)

Categories

(Thunderbird :: Build Config, defect)

15 Branch
defect
Not set

Tracking

(thunderbird15+ fixed)

RESOLVED FIXED
Thunderbird 16.0
Tracking Status
thunderbird15 + fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
Somehow in my testing, I discovered that Thunderbird isn't creating an update-settings.ini file.

This file is currently used for double-checking the correct mar is apply to the correct build on a multi-build system, but is unused for Thunderbird as we haven't quite got that far yet.

However, for some reason the unit tests require it, and since we'll be getting it anyway, I think we should just pick it up.

If we set MOZ_APP_BASENAME, then mozilla/build will also generate an application.ini, but that will get overwritten by the one in mail/app, so that will be fine. We'll pick up the core one when we can.

Try server builds with this patch available here:

https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/bugzilla@standard8.plus.com-1d657d398f2f/

The change is basically a no-op for us, apart from adding that update-settings.ini file, I diffed a windows build from that directory with the nightly build and the only differences were the expected ones.
Attachment #639276 - Flags: review?(mconley)
Version: 13 → 15
Comment on attachment 639276 [details] [diff] [review]
The fix

Looks good to me. Thanks.
Attachment #639276 - Flags: review?(mconley) → review+
Checked in:

https://hg.mozilla.org/comm-central/rev/b3222ecb9e88
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 639276 [details] [diff] [review]
The fix

[Triage Comment]
This doesn't seem to have had any negative impacts on trunk, and we want this on aurora as well to fix the test failures there.
Attachment #639276 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.