Closed Bug 771085 Opened 8 years ago Closed 8 years ago
_APP _BASENAME for Thunderbird to help fix Permanent orange: TEST-UNEXPECTED-FAIL | test _0200 _app _launch _apply _update .js failures (and test _0201 ..., test _0203 ...)
Somehow in my testing, I discovered that Thunderbird isn't creating an update-settings.ini file. This file is currently used for double-checking the correct mar is apply to the correct build on a multi-build system, but is unused for Thunderbird as we haven't quite got that far yet. However, for some reason the unit tests require it, and since we'll be getting it anyway, I think we should just pick it up. If we set MOZ_APP_BASENAME, then mozilla/build will also generate an application.ini, but that will get overwritten by the one in mail/app, so that will be fine. We'll pick up the core one when we can. Try server builds with this patch available here: https://email@example.com/ The change is basically a no-op for us, apart from adding that update-settings.ini file, I diffed a windows build from that directory with the nightly build and the only differences were the expected ones.
Attachment #639276 - Flags: review?(mconley)
Comment on attachment 639276 [details] [diff] [review] The fix Looks good to me. Thanks.
Attachment #639276 - Flags: review?(mconley) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 639276 [details] [diff] [review] The fix [Triage Comment] This doesn't seem to have had any negative impacts on trunk, and we want this on aurora as well to fix the test failures there.
Attachment #639276 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.