Last Comment Bug 771085 - Define MOZ_APP_BASENAME for Thunderbird to help fix Permanent orange: TEST-UNEXPECTED-FAIL | test_0200_app_launch_apply_update.js failures (and test_0201..., test_0203...)
: Define MOZ_APP_BASENAME for Thunderbird to help fix Permanent orange: TEST-UN...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: 15 Branch
: All All
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Mark Banner (:standard8, limited time in Dec)
:
:
Mentors:
Depends on: 766264
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-05 03:43 PDT by Mark Banner (:standard8, limited time in Dec)
Modified: 2012-07-10 15:23 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed


Attachments
The fix (520 bytes, patch)
2012-07-05 03:43 PDT, Mark Banner (:standard8, limited time in Dec)
mconley: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description Mark Banner (:standard8, limited time in Dec) 2012-07-05 03:43:43 PDT
Created attachment 639276 [details] [diff] [review]
The fix

Somehow in my testing, I discovered that Thunderbird isn't creating an update-settings.ini file.

This file is currently used for double-checking the correct mar is apply to the correct build on a multi-build system, but is unused for Thunderbird as we haven't quite got that far yet.

However, for some reason the unit tests require it, and since we'll be getting it anyway, I think we should just pick it up.

If we set MOZ_APP_BASENAME, then mozilla/build will also generate an application.ini, but that will get overwritten by the one in mail/app, so that will be fine. We'll pick up the core one when we can.

Try server builds with this patch available here:

https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/bugzilla@standard8.plus.com-1d657d398f2f/

The change is basically a no-op for us, apart from adding that update-settings.ini file, I diffed a windows build from that directory with the nightly build and the only differences were the expected ones.
Comment 1 Mike Conley (:mconley) 2012-07-05 07:18:30 PDT
Comment on attachment 639276 [details] [diff] [review]
The fix

Looks good to me. Thanks.
Comment 2 Mark Banner (:standard8, limited time in Dec) 2012-07-05 13:28:58 PDT
Checked in:

https://hg.mozilla.org/comm-central/rev/b3222ecb9e88
Comment 3 Mark Banner (:standard8, limited time in Dec) 2012-07-10 05:51:04 PDT
Comment on attachment 639276 [details] [diff] [review]
The fix

[Triage Comment]
This doesn't seem to have had any negative impacts on trunk, and we want this on aurora as well to fix the test failures there.
Comment 4 Mark Banner (:standard8, limited time in Dec) 2012-07-10 15:23:15 PDT
Checked in:

https://hg.mozilla.org/releases/comm-aurora/rev/a398b69b5c92

Note You need to log in before you can comment on or make changes to this bug.