Closed Bug 771148 Opened 8 years ago Closed 8 years ago

Make NS_CheckThreadSafe fatal

Categories

(Core :: XPCOM, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 753659

People

(Reporter: bjacob, Unassigned)

Details

Attachments

(1 file)

In bug 754572, we have a security bug that is made harder to debug by the non-fatality of the assertion in NS_CheckThreadSafe. In this bug, we landed a patch adding a MOZ_FATAL_ASSERTIONS_FOR_THREAD_SAFETY option making it fatal, and using in a couple of cpp files relevant to this bug.

Ideally, this assertion should be fatal because when it fails, it's a programming mistake in our C++ code and it can lead to arbitrary bad things. The question is can we make it fatal now without regressions? Let's do some tryserver runs and try to land this at the beginning of the next release cycle.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 753659
You need to log in before you can comment on or make changes to this bug.