771148 - Make NS_CheckThreadSafe fatal

Status: RESOLVED DUPLICATE of bug 753659

(Core :: XPCOM, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 754572, we have a security bug that is made harder to debug by the non-fatality of the assertion in NS_CheckThreadSafe. In this bug, we landed a patch adding a MOZ_FATAL_ASSERTIONS_FOR_THREAD_SAFETY option making it fatal, and using in a couple of cpp files relevant to this bug.

Ideally, this assertion should be fatal because when it fails, it's a programming mistake in our C++ code and it can lead to arbitrary bad things. The question is can we make it fatal now without regressions? Let's do some tryserver runs and try to land this at the beginning of the next release cycle.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: always fatal NS_CheckThreadSafe

https://tbpl.mozilla.org/?tree=Try&rev=97f88b8a3e65