771198 - improve error output of run_cmd

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: move error output

Noticed this during a push-to-mirrors.py failure in Tb14.0b4. We get output like:
command: START
command: ssh -l tbirdbld -i /home/cltbld/.ssh/tbirdbld_dsa stage.mozilla.org 'test "0" = "$(find /pub/mozilla.org/thunderbird/nightly/14.0b4-candidates/build1/ -mindepth 1 -type d ! -perm 755 ! -path \'*/contrib*\' ! -path \'*/partner-repacks*\' | wc -l)"'
command: cwd: /builds/slave/tb-rel-c-beta-chk-prms
command: output:
command: END (0.57s elapsed)

Error while running: find /pub/mozilla.org/thunderbird/nightly/14.0b4-candidates/build1/ -mindepth 1 -type d ! -perm 755 ! -path '*/contrib*' ! -path '*/partner-repacks*'
command: START
command: ssh -l tbirdbld -i /home/cltbld/.ssh/tbirdbld_dsa stage.mozilla.org 'test "0" = "$(find /pub/mozilla.org/thunderbird/nightly/14.0b4-candidates/build1/ -maxdepth 1 -type d ! -perm 2775 -path \'*/contrib*\' | wc -l)"'
command: cwd: /builds/slave/tb-rel-c-beta-chk-prms
command: output:
command: END (0.38s elapsed)


Note that the "Error" line is closer to the *next* command rather than the one that fails. This is because that output comes from push-to-mirrors.py. By moving the error printing to run_cmd.py we can keep it within the same "block", making it easier to read.