771206 - [style editor] re-apply the modified stylesheets when the page is reloaded.

Status: NEW

(DevTools :: Style Editor, enhancement, P3)

Comment 1

[Paul Rouget [:paul]]

Bug triage, filter on PINKISBEAUTIFUL

Comment 2

[Girish Sharma [:Optimizer]]

This does not seem to be a toolbox regression. It is related to dead access to reloaded contentWindow, most probably due to the strict access rules introduced in Firefox 17.

Should this still be bocking 816946

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, it should ... that list is not only for toolbox regressions, it is a list of things we need to fix before Firefox 20 is released.

Comment 4

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #2)
> This does not seem to be a toolbox regression. It is related to dead access
> to reloaded contentWindow, most probably due to the strict access rules
> introduced in Firefox 17.

Because of the Toolbox, the StyleEditor needs to support page reloading.

Comment 5

[Paul Rouget [:paul]]

Heather, do you think we can get that into Firefox 20?

Comment 6

[Heather Arthur [:harth]]

(In reply to Paul Rouget [:paul] from comment #5)
> Heather, do you think we can get that into Firefox 20?

I wasn't planning on it, because it seemed like a problem with a lot of edge cases. Which is why I was advocating bug 826982 for 20.

This is my main priority right now though, so maybe?

The big edge case is if the file changes on disk or the server and the changes no longer apply cleanly upon refresh. My thoughts were to get a diff of changes before the page reloads, if the changes no longer apply, offer an option to export it as a diff or just revert the files.

Comment 7

[Paul Rouget [:paul]]

(In reply to Heather Arthur [:harth] from comment #6)
> (In reply to Paul Rouget [:paul] from comment #5)
> > Heather, do you think we can get that into Firefox 20?
> 
> I wasn't planning on it, because it seemed like a problem with a lot of edge
> cases. Which is why I was advocating bug 826982 for 20.

I see.

> The big edge case is if the file changes on disk or the server and the
> changes no longer apply cleanly upon refresh. My thoughts were to get a diff
> of changes before the page reloads, if the changes no longer apply, offer an
> option to export it as a diff or just revert the files.

Indeed, that sounds tricky.

Maybe you're right, and bug 826982 is what we should do for now until the styleeditor reboot.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We discussed this in London concluding that when a page is refreshed and there were changes to a stylesheet the user should have the choice to either load the stylesheets with changes or to reload them all.

We also said that each stylesheet should have an option to revert.

Comment 9

[Patrick Brosset <:pbro>]

Triaging. This has been a P1 for more than 3 years with no significant activity. Returning to the backlog. (Filter on CLIMBING SHOES).

Comment 10

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 11

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).