[style editor] re-apply the modified stylesheets when the page is reloaded.

NEW
Unassigned

Status

()

Firefox
Developer Tools: Style Editor
P3
enhancement
6 years ago
4 months ago

People

(Reporter: paul, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Comment hidden (empty)
(Reporter)

Updated

6 years ago
Blocks: 771203
(Reporter)

Comment 1

5 years ago
Bug triage, filter on PINKISBEAUTIFUL
Blocks: 816946
(Reporter)

Updated

5 years ago
Priority: -- → P1
This does not seem to be a toolbox regression. It is related to dead access to reloaded contentWindow, most probably due to the strict access rules introduced in Firefox 17.

Should this still be bocking 816946
Yes, it should ... that list is not only for toolbox regressions, it is a list of things we need to fix before Firefox 20 is released.
(Reporter)

Comment 4

5 years ago
(In reply to Girish Sharma [:Optimizer] from comment #2)
> This does not seem to be a toolbox regression. It is related to dead access
> to reloaded contentWindow, most probably due to the strict access rules
> introduced in Firefox 17.

Because of the Toolbox, the StyleEditor needs to support page reloading.
Assignee: nobody → fayearthur
Blocks: 831711
(Reporter)

Comment 5

5 years ago
Heather, do you think we can get that into Firefox 20?
Flags: needinfo?(fayearthur)
(In reply to Paul Rouget [:paul] from comment #5)
> Heather, do you think we can get that into Firefox 20?

I wasn't planning on it, because it seemed like a problem with a lot of edge cases. Which is why I was advocating bug 826982 for 20.

This is my main priority right now though, so maybe?

The big edge case is if the file changes on disk or the server and the changes no longer apply cleanly upon refresh. My thoughts were to get a diff of changes before the page reloads, if the changes no longer apply, offer an option to export it as a diff or just revert the files.
Flags: needinfo?(fayearthur)
(Reporter)

Comment 7

5 years ago
(In reply to Heather Arthur [:harth] from comment #6)
> (In reply to Paul Rouget [:paul] from comment #5)
> > Heather, do you think we can get that into Firefox 20?
> 
> I wasn't planning on it, because it seemed like a problem with a lot of edge
> cases. Which is why I was advocating bug 826982 for 20.

I see.

> The big edge case is if the file changes on disk or the server and the
> changes no longer apply cleanly upon refresh. My thoughts were to get a diff
> of changes before the page reloads, if the changes no longer apply, offer an
> option to export it as a diff or just revert the files.

Indeed, that sounds tricky.

Maybe you're right, and bug 826982 is what we should do for now until the styleeditor reboot.
No longer blocks: 816946
(Reporter)

Updated

5 years ago
Blocks: 831709
We discussed this in London concluding that when a page is refreshed and there were changes to a stylesheet the user should have the choice to either load the stylesheets with changes or to reload them all.

We also said that each stylesheet should have an option to revert.
Assignee: fayearthur → nobody
Triaging. This has been a P1 for more than 3 years with no significant activity. Returning to the backlog. (Filter on CLIMBING SHOES).
Priority: P1 → --
Inspector bug triage (filter on CLIMBING SHOES).
Severity: normal → enhancement
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.