771207 - Permanent orange: TEST-UNEXPECTED-FAIL | test_temporaryFilesRemoved.js | TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]" nsresult: "0x80004005 (NS_ERROR_FAILURE)"

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Just showed up on our XPCshell tests - seems to apply on each platform.

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>

TEST-INFO | (xpcshell/head.js) | test 1 pending
Directory request for: MailD that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: MFCaF that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: DefRt that we (mailDirService.js) are not handling, leaving it to another handler.

TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js :: run_test :: line 101"  data: no]
<<<<<<<
TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | running test ...
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>

TEST-INFO | (xpcshell/head.js) | test 1 pending
Directory request for: MailD that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: MFCaF that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: DefRt that we (mailDirService.js) are not handling, leaving it to another handler.

TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js :: run_test :: line 101"  data: no]

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

So we now pass in null instead of our fake docShell.

This also required me to remove the call to CloseWindow (which assumes we have a non-null docShell, I guess).

Is that OK, or should we modify CloseWindow to account for no docShell?

-Mike

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 639429 [details] [diff] [review]
Patch v1

The test doesn't show any leaks after the patch, so I think it is fine to remove the close window.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/cab17ecd7ab8