Last Comment Bug 771207 - Permanent orange: TEST-UNEXPECTED-FAIL | test_temporaryFilesRemoved.js | TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]" nsresult: "0x80004005 (NS_ERROR_FAILURE)"
: Permanent orange: TEST-UNEXPECTED-FAIL | test_temporaryFilesRemoved.js | TEST...
Status: RESOLVED FIXED
: intermittent-failure
Product: Thunderbird
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Mike Conley (:mconley) - (Needinfo me!)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-05 10:04 PDT by Mike Conley (:mconley) - (Needinfo me!)
Modified: 2012-11-25 19:31 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (2.02 KB, patch)
2012-07-05 12:35 PDT, Mike Conley (:mconley) - (Needinfo me!)
standard8: review+
Details | Diff | Review

Description Mike Conley (:mconley) - (Needinfo me!) 2012-07-05 10:04:30 PDT
Just showed up on our XPCshell tests - seems to apply on each platform.

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>

TEST-INFO | (xpcshell/head.js) | test 1 pending
Directory request for: MailD that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: MFCaF that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: DefRt that we (mailDirService.js) are not handling, leaving it to another handler.

TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js :: run_test :: line 101"  data: no]
<<<<<<<
TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | running test ...
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>

TEST-INFO | (xpcshell/head.js) | test 1 pending
Directory request for: MailD that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: MFCaF that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: DefRt that we (mailDirService.js) are not handling, leaving it to another handler.

TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Failure arg 2 [nsIMsgCompose.initialize]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/compose/test/unit/test_temporaryFilesRemoved.js :: run_test :: line 101"  data: no]
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-07-05 12:35:02 PDT
Created attachment 639429 [details] [diff] [review]
Patch v1

So we now pass in null instead of our fake docShell.

This also required me to remove the call to CloseWindow (which assumes we have a non-null docShell, I guess).

Is that OK, or should we modify CloseWindow to account for no docShell?

-Mike
Comment 2 Mark Banner (:standard8) 2012-07-05 13:12:03 PDT
Comment on attachment 639429 [details] [diff] [review]
Patch v1

The test doesn't show any leaks after the patch, so I think it is fine to remove the close window.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2012-07-05 13:19:17 PDT
comm-central: https://hg.mozilla.org/comm-central/rev/cab17ecd7ab8

Note You need to log in before you can comment on or make changes to this bug.