Closed
Bug 771215
Opened 12 years ago
Closed 10 years ago
Copy Username menu item does not have access key in Saved Passwords box
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: sankha, Assigned: yfdyh000)
References
Details
Attachments
(1 file, 1 obsolete file)
1.76 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
Following up Bug 656011 - Saved passwords box does not provide a way to copy username, the current context menu item "Copy Username" does not have an access key. Adding an access to the menu item will be helpful.
Reporter | ||
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
This have a little anti-sense issue, the second menu item using the first letter, but it seem innocuous, since usage of these two menus.
Comment 2•10 years ago
|
||
Comment on attachment 8503981 [details] [diff] [review] 771215.patch Review of attachment 8503981 [details] [diff] [review]: ----------------------------------------------------------------- Flag me again for review if "U" isn't available. ::: toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd @@ +32,5 @@ > <!ENTITY copyPasswordCmd.label "Copy Password"> > <!ENTITY copyPasswordCmd.accesskey "C"> > > <!ENTITY copyUsernameCmd.label "Copy Username"> > +<!ENTITY copyUsernameCmd.accesskey "O"> Was "U" not available? It would be much better in my opinion and match with https://developer.mozilla.org/en-US/docs/XUL_Accesskey_FAQ_and_Policies#How_do_I_pick_an_accesskey_letter.3F
Attachment #8503981 -
Flags: review?(MattN+bmo) → feedback+
(In reply to Matthew N. [:MattN] (behind on reviews - focused on Loop) from comment #2) > Was "U" not available? It would be much better in my opinion and match with > https://developer.mozilla.org/en-US/docs/ > XUL_Accesskey_FAQ_and_Policies#How_do_I_pick_an_accesskey_letter.3F I thought about it, but eventually I wrong to think the should be in alphabetical order. Thanks for the doc. Originally, I also want to ask about whether to replace with Copy &Password, but I just saw the "Letters with descenders, such as p, g, q, or y." in the doc, so I seem should to giving up it. I will upload a new patch to review.
Attachment #8503981 -
Attachment is obsolete: true
Attachment #8505121 -
Flags: review?(MattN+bmo)
Comment 5•10 years ago
|
||
Comment on attachment 8505121 [details] [diff] [review] patch v1 Thanks!
Attachment #8505121 -
Flags: review?(MattN+bmo) → review+
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Hi, do you have a try link (just to make sure everything works) ?
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f707c1692a77
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f707c1692a77
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•