771390 - [css3-mediaqueries] resolution units (dpi, dpcm, dppx) should be dots per CSS inch/centimeter/pixel, not per physical in/cm/px

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

css3-mediaqueries now says that the dpi, dpcm (and future dppx) units are dots per *CSS* inch, not dots per physical inch.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

with more tests

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Basically passed try (though a few Windows tests still pending):
try: --build d --platform linux,macosx64,win32,android --unittests all --talos none --no-emails
https://tbpl.mozilla.org/?tree=Try&rev=afa60b026c46

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 639542 [details] [diff] [review]
patch

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e509374cbd1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e509374cbd1

Comment 7

[Jean-Yves Perrier [:teoli]]

Added a line in 
https://developer-new.mozilla.org/en-US/docs/CSS/resolution
and in
https://developer-new.mozilla.org/en-US/docs/Firefox_16_for_developers

(Visible on the real site when Kuma will come live!)