Closed Bug 771439 Opened 9 years ago Closed 4 years ago

Text in Thunderbird's account provisioner dialog is not right aligned in Arabic locale

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Version:
14 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 55.0

People

(Reporter: dr.khaled.hosny, Assigned: Paenglab)

References

(Depends on 1 open bug)

Details

(Keywords: rtl, Whiteboard: [good first bug][lang=xhtml])

Attachments

(2 files)

Screenshot
40.29 KB, image/png
Details
Bug771439.patch
1.52 KB, patch
aceman
: review+
Details | Diff | Splinter Review
Attached image Screenshot — 
The text in in Thunderbird's account provisioner dialog is not right aligned in Arabic locale, which (besides looking ugly) makes the disclaimer text almost incomprehensible because the intervention provider names breaking the order of the sentences. This might affect other right to left locales as well, but I only tested Arabic.
Keywords: rtl
Status: UNCONFIRMED → NEW
Ever confirmed: true
Indeed this bug sometimes prevents me from using Thunderbird. This bug doesn't happen in Gedit, when using Gedit all I have to do is to change the layout between Arabic and English and the order of the phrase doesn't get affected.

 This bug happens when I write an e-mail which has mixture of a right to left language like Arabic and a left to right language like English. The order of the  phrase becomes wrong.
 For example the following phrase says that my name is Yousef, my e-mail is “goku_goken2@yahoo.com” and I hope that you contact me ASAP”

That's a picture expalins what happens:

http://im75.gulfup.com/aCtAjr.png

The text in the previous picture is 
"السلام عليكم 

أنا اسمي يوسف، وبريدي الإلكتروني goku_goken2@yahoo.com أرجو أن تراسلني في أقرب وقت ممكن.”


I hope this help. Good luck.
Depends on: 552495
This might be easy to fix per bug 552495 by changing XUL alignment to start/end instead of left/right. Not sure how that works out with variables for inserted text like email addresses etc.
Whiteboard: [good first bug]
Paenglab, do you have experience with this?
Flags: needinfo?(richard.marti)
Whiteboard: [good first bug] → [good first bug][lang=xul]
The direction needs to be set in accountProvisioner.xhtml like <html dir="rtl"...> but depending the locale set maybe in the dtd file.
Flags: needinfo?(richard.marti)
Whiteboard: [good first bug][lang=xul] → [good first bug][lang=xhtml]
(In reply to Richard Marti (:Paenglab) from comment #4)
> The direction needs to be set in accountProvisioner.xhtml like <html
> dir="rtl"...> but depending the locale set maybe in the dtd file.

You should import the global.dtd file and append the attribute dir=&locale.dir; into the <html> or <body> elements on that file.
Attached patch Bug771439.patch — — Splinter Review 
I'm taking this to let it no longer lie around.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8847219 - Flags: review?(acelists)
Comment on attachment 8847219 [details] [diff] [review]
Bug771439.patch

Review of attachment 8847219 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't tested it in Arabic, but the global.dtd file does contain "rtl" for Arabic, https://dxr.mozilla.org/l10n-central/source/ar/dom/chrome/global.dtd#5 .
Thanks.
Attachment #8847219 - Flags: review?(acelists) → review+
https://hg.mozilla.org/comm-central/rev/6f7b36eb5ee1c842212aab5e463ab1caca8255af
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.