Last Comment Bug 771452 - resume button need two clicks to go on after a breakpoint when the script is inside the .html file
: resume button need two clicks to go on after a breakpoint when the script is ...
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: 15 Branch
: x86_64 Linux
P2 normal (vote)
: Firefox 16
Assigned To: Panos Astithas [:past]
: Jason Laster [:jlast]
Depends on: 773653
  Show dependency treegraph
Reported: 2012-07-06 02:51 PDT by Alfredos-Panagiotis Damkalis [:fredy]
Modified: 2012-07-24 02:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Test page (358 bytes, text/html)
2012-07-06 02:51 PDT, Alfredos-Panagiotis Damkalis [:fredy]
no flags Details
Working patch (6.42 KB, patch)
2012-07-09 07:54 PDT, Panos Astithas [:past]
rcampbell: review+
Details | Diff | Splinter Review
Working patch v2 (6.26 KB, patch)
2012-07-12 11:29 PDT, Panos Astithas [:past]
no flags Details | Diff | Splinter Review
Working patch v3 (5.88 KB, patch)
2012-07-12 13:45 PDT, Panos Astithas [:past]
no flags Details | Diff | Splinter Review

Description User image Alfredos-Panagiotis Damkalis [:fredy] 2012-07-06 02:51:04 PDT
Created attachment 639612 [details]
Test page

tested with latest Aurora (Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120705 Firefox/15.0a2) and latest nightly (Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0)

Steps to reproduce:

1. Open the attached file
2. Open the debugger
3. Set a breakpoint on the 10th line (document.getElementById("demo").innerHTML=x;)
4. Click Run
5. The execution stops at the breakpoint
6. Click resume button once

What happens:

Nothing happens, except that it seems to reload something at the "Global Scope [Window]".

Note that if you click one more time at the resume button the execution goes on normally.

What should happen:

It should have the same behavior as when the script is in an external file. So it should go on after the breakpoint with only one click.

Note that the same behavior exists on step in/over/out.
Comment 1 User image Panos Astithas [:past] 2012-07-09 03:33:36 PDT
This was introduced with the patch for bug 737808. We add stored breakpoints for new scripts, without making sure that the lines in the stored breakpoints exist in those scripts.
Comment 2 User image Panos Astithas [:past] 2012-07-09 07:54:03 PDT
Created attachment 640213 [details] [diff] [review]
Working patch

The two-line fix and a test. Nice catch fredy!
Comment 3 User image Rob Campbell [:rc] (:robcee) 2012-07-10 12:58:09 PDT
Comment on attachment 640213 [details] [diff] [review]
Working patch

I've noticed this bug!

r+ with a try run!
Comment 4 User image Panos Astithas [:past] 2012-07-11 01:39:38 PDT
Try run:
Comment 5 User image Panos Astithas [:past] 2012-07-12 11:29:55 PDT
Created attachment 641546 [details] [diff] [review]
Working patch v2

The test produced a couple of oranges, so I simplified it a bit to avoid them. New try:
Comment 6 User image Panos Astithas [:past] 2012-07-12 13:45:13 PDT
Created attachment 641581 [details] [diff] [review]
Working patch v3

OK, so I got oranges again. Sue me. But this time I found a way to test the fix without depending on the test page being updated at all. Final try (famous last words):
Comment 7 User image Panos Astithas [:past] 2012-07-13 05:22:07 PDT
I told ya it would work!
Comment 8 User image Ed Morley [:emorley] 2012-07-13 07:58:28 PDT
The test added in the landing above, leaked on it's first run:

TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_breakpoint-new-script.js | leaked 2 window(s) until shutdown [url =]
Comment 9 User image Ed Morley [:emorley] 2012-07-16 05:27:37 PDT
Comment 10 User image Alfredos-Panagiotis Damkalis [:fredy] 2012-07-24 02:02:42 PDT
Verified fixed on the latest Aurora and Nightly


Note You need to log in before you can comment on or make changes to this bug.