771559 - HTML's "valid floating point number" doesn't match ToDouble()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

See: 
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#valid-floating-point-number

I haven't checked more deeply than that but it seems at least that we allow stuff like "+22" while HTML algorithm refuses it.
FWIW, Webkit and Presto are following the specs.

Comment 1

[Jonathan Watt [:jwatt]]

I should be able to get what we want using StringToDoubleConverter, I think.

Comment 2

[Jonathan Watt [:jwatt]]

Interesting thread on HTML vs. JS number parsing:

http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-August/thread.html#32792

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] from comment #1)
> I should be able to get what we want using StringToDoubleConverter, I think.

Actually, no. We now have webcore's Decimal class and, like for NS_FORM_INPUT_RANGE, we should use HTMLInputElement::ConvertStringToNumber, which uses webcore's Decimal::fromString, which Google has written to conform to the HTML5's rules for a "valid floating point number":

https://mxr.mozilla.org/mozilla-central/source/mfbt/decimal/Decimal.h?mark=165-172&rev=a296036e608f#165

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Olli Pettay [:smaug]]

Comment on attachment 8336809 [details] [diff] [review]
patch

Some test would be nice.

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/836ee14f6a37

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/836ee14f6a37